net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc - Issue 6831025: Adds support for the DHCP portion of the WPAD (proxy auto-discovery) protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc

Issue 6831025: Adds support for the DHCP portion of the WPAD (proxy auto-discovery) protocol. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix memory leaks in unit test. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/proxy/dhcp_proxy_script_fetcher_factory.cc ('k') | net/proxy/dhcp_proxy_script_fetcher_win.h » ('j') | net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc

diff --git a/net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc b/net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc

index 2c29120ac8b0cdca4f036e62b53c77a7701632c0..a9ed9c3b1b320d51ce5ee90e2805ca8b2a6ef446 100644

--- a/net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc

+++ b/net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc

@@ -12,9 +12,7 @@ namespace {

TEST(DhcpProxyScriptFetcherFactoryTest, DoNothingWhenDisabled) {

DhcpProxyScriptFetcherFactory factory;

- // Non-do-nothing fetchers would DCHECK on the NULL pointer.

- DhcpProxyScriptFetcher* fetcher = factory.Create(NULL);

- ASSERT_TRUE(fetcher);

+ scoped_ptr<DhcpProxyScriptFetcher> fetcher(factory.Create(NULL));

EXPECT_EQ("", fetcher->GetFetcherName());

}

@@ -24,8 +22,7 @@ TEST(DhcpProxyScriptFetcherFactoryTest, WindowsFetcherOnWindows) {

factory.set_enabled(true);

scoped_refptr<TestURLRequestContext> context(new TestURLRequestContext());

- DhcpProxyScriptFetcher* fetcher = factory.Create(context);

- ASSERT_TRUE(fetcher);

+ scoped_ptr<DhcpProxyScriptFetcher> fetcher(factory.Create(context));

EXPECT_EQ("win", fetcher->GetFetcherName());

}

#endif // defined(OS_WIN)