Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc

Issue 6831025: Adds support for the DHCP portion of the WPAD (proxy auto-discovery) protocol. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix issue found by unit testing on a slow machine. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc
diff --git a/net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc b/net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a7dab9e1ace2dbe96463bfcaa3701e5cced1e501
--- /dev/null
+++ b/net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc
@@ -0,0 +1,255 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/timer.h"
+#include "base/perftimer.h"
+#include "net/base/net_errors.h"
+#include "net/proxy/dhcp_proxy_script_adapter_fetcher_win.h"
+#include "net/proxy/mock_proxy_script_fetcher.h"
+#include "net/test/test_server.h"
+#include "net/url_request/url_request_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+
+const char* const kPacUrl = "http://pacserver/script.pac";
+
+namespace {
+
+// In net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc there are a few
+// tests that exercise DhcpProxyScriptAdapterFetcher end-to-end along with
+// WindowsDhcpProxyScriptFetcher, i.e. it tests the end-to-end usage of Win32
+// APIs and the network. In this file we test only by stubbing out
+// functionality.
+
+// Version of DhcpProxyScriptAdapterFetcher that mocks out dependencies
+// to allow unit testing.
+class MockDhcpProxyScriptAdapterFetcher : public DhcpProxyScriptAdapterFetcher {
+ public:
+ explicit MockDhcpProxyScriptAdapterFetcher()
+ : DhcpProxyScriptAdapterFetcher(new TestURLRequestContext()),
+ dhcp_delay_ms_(1),
+ timeout_ms_(100),
+ configured_url_(kPacUrl),
+ fetcher_delay_ms_(1),
+ fetcher_result_(OK),
+ pac_script_("bingo") {
+ }
+
+ void Cancel() {
+ DhcpProxyScriptAdapterFetcher::Cancel();
+ fetcher_ = NULL;
+ }
+
+ std::string ImplGetPacURLFromDhcp(const std::string& adapter_name) OVERRIDE {
+ base::PlatformThread::Sleep(dhcp_delay_ms_);
+ return configured_url_;
+ }
+
+ virtual ProxyScriptFetcher* ImplCreateScriptFetcher(
+ const GURL& url) OVERRIDE {
+ // We don't maintain ownership of the fetcher, it is transferred to
+ // the caller.
+ fetcher_ = new MockProxyScriptFetcher();
+ fetcher_->SetURL(url);
+ if (fetcher_delay_ms_ != -1) {
+ fetcher_timer_.Start(
+ base::TimeDelta::FromMilliseconds(fetcher_delay_ms_),
+ this, &MockDhcpProxyScriptAdapterFetcher::OnFetcherTimer);
+ }
+ return fetcher_;
+ }
+
+ // Use a shorter timeout so tests can finish more quickly.
+ virtual int ImplGetTimeoutMs() const OVERRIDE {
+ return timeout_ms_;
+ }
+
+ void OnFetcherTimer() {
+ DCHECK(fetcher_);
+ fetcher_->NotifyFetchCompletion(fetcher_result_, pac_script_);
+ fetcher_ = NULL;
+ }
+
+ bool IsWaitingForFetcher() const {
+ return state_ == STATE_WAIT_URL;
+ }
+
+ bool WasCancelled() const {
+ return state_ == STATE_CANCEL;
+ }
+
+ int dhcp_delay_ms_;
+ int timeout_ms_;
+ std::string configured_url_;
+ int fetcher_delay_ms_;
+ int fetcher_result_;
+ std::string pac_script_;
+ MockProxyScriptFetcher* fetcher_;
+ base::OneShotTimer<MockDhcpProxyScriptAdapterFetcher> fetcher_timer_;
+};
+
+class FetcherClient {
+public:
+ FetcherClient()
+ : finished_(false),
+ fetcher_(new MockDhcpProxyScriptAdapterFetcher()),
+ ALLOW_THIS_IN_INITIALIZER_LIST(
+ completion_callback_(this, &FetcherClient::OnCompletion)) {
+ }
+
+ void RunTest() {
+ fetcher_->Fetch("adapter name", &completion_callback_);
+ }
+
+ void RunMessageLoopUntilComplete() {
+ while (!finished_) {
+ MessageLoop::current()->RunAllPending();
+ }
+ MessageLoop::current()->RunAllPending();
+ }
+
+ void OnCompletion(int result) {
+ finished_ = true;
+ }
+
+ bool finished_;
+ scoped_refptr<MockDhcpProxyScriptAdapterFetcher> fetcher_;
+ string16 pac_text_;
+ CompletionCallbackImpl<FetcherClient> completion_callback_;
+};
+
+TEST(DhcpProxyScriptAdapterFetcher, NormalCaseURLNotInDhcp) {
+ FetcherClient client;
+ client.fetcher_->configured_url_ = "";
+ client.RunTest();
+ client.RunMessageLoopUntilComplete();
+ ASSERT_TRUE(client.fetcher_->DidFinish());
+ EXPECT_EQ(ERR_PAC_NOT_IN_DHCP, client.fetcher_->result());
+ EXPECT_EQ(string16(L""), client.fetcher_->pac_script());
+}
+
+TEST(DhcpProxyScriptAdapterFetcher, NormalCaseURLInDhcp) {
+ FetcherClient client;
+ client.RunTest();
+ client.RunMessageLoopUntilComplete();
+ ASSERT_TRUE(client.fetcher_->DidFinish());
+ EXPECT_EQ(OK, client.fetcher_->result());
+ EXPECT_EQ(string16(L"bingo"), client.fetcher_->pac_script());
+ EXPECT_EQ(GURL(kPacUrl), client.fetcher_->pac_url());
+}
+
+TEST(DhcpProxyScriptAdapterFetcher, TimeoutDuringDhcp) {
+ // Does a Fetch() with a long enough delay on accessing DHCP that the
+ // fetcher should time out. This is to test a case manual testing found,
+ // where under certain circumstances (e.g. adapter enabled for DHCP and
+ // needs to retrieve its configuration from DHCP, but no DHCP server
+ // present on the network) accessing DHCP can take on the order of tens
+ // of seconds.
+ FetcherClient client;
+ client.fetcher_->dhcp_delay_ms_ = 20 * 1000;
+ client.fetcher_->timeout_ms_ = 25;
+
+ PerfTimer timer;
+ client.RunTest();
+ client.RunMessageLoopUntilComplete();
+
+ // The timeout should occur within about 25 ms, way before the 20s set as
+ // the API delay above.
+ ASSERT_GT(base::TimeDelta::FromMilliseconds(35), timer.Elapsed());
+ ASSERT_TRUE(client.fetcher_->DidFinish());
+ EXPECT_EQ(ERR_TIMED_OUT, client.fetcher_->result());
+ EXPECT_EQ(string16(L""), client.fetcher_->pac_script());
+ EXPECT_EQ(GURL(), client.fetcher_->pac_url());
+}
+
+TEST(DhcpProxyScriptAdapterFetcher, CancelWhileDhcp) {
+ FetcherClient client;
+ client.fetcher_->dhcp_delay_ms_ = 10;
+ client.RunTest();
+ client.fetcher_->Cancel();
+ MessageLoop::current()->RunAllPending();
+ ASSERT_FALSE(client.fetcher_->DidFinish());
+ ASSERT_TRUE(client.fetcher_->WasCancelled());
+ EXPECT_EQ(ERR_ABORTED, client.fetcher_->result());
+ EXPECT_EQ(string16(L""), client.fetcher_->pac_script());
+ EXPECT_EQ(GURL(), client.fetcher_->pac_url());
+}
+
+TEST(DhcpProxyScriptAdapterFetcher, CancelWhileFetcher) {
+ FetcherClient client;
+ // This causes the mock fetcher not to pretend the
+ // fetcher finishes after a timeout.
+ client.fetcher_->fetcher_delay_ms_ = -1;
+ client.RunTest();
+ int max_loops = 4;
+ while (!client.fetcher_->IsWaitingForFetcher() && max_loops--) {
+ base::PlatformThread::Sleep(10);
+ MessageLoop::current()->RunAllPending();
+ }
+ client.fetcher_->Cancel();
+ MessageLoop::current()->RunAllPending();
+ ASSERT_FALSE(client.fetcher_->DidFinish());
+ ASSERT_TRUE(client.fetcher_->WasCancelled());
+ EXPECT_EQ(ERR_ABORTED, client.fetcher_->result());
+ EXPECT_EQ(string16(L""), client.fetcher_->pac_script());
+ // GetPacURL() still returns the URL fetched in this case.
+ EXPECT_EQ(GURL(kPacUrl), client.fetcher_->pac_url());
+}
+
+TEST(DhcpProxyScriptAdapterFetcher, CancelAtCompletion) {
+ FetcherClient client;
+ client.RunTest();
+ client.RunMessageLoopUntilComplete();
+ client.fetcher_->Cancel();
+ // Canceling after you're done should have no effect, so these
+ // are identical expectations to the NormalCaseURLInDhcp test.
+ ASSERT_TRUE(client.fetcher_->DidFinish());
+ EXPECT_EQ(OK, client.fetcher_->result());
+ EXPECT_EQ(string16(L"bingo"), client.fetcher_->pac_script());
+ EXPECT_EQ(GURL(kPacUrl), client.fetcher_->pac_url());
+}
+
+// Does a real fetch on a mock DHCP configuration.
+class MockDhcpRealFetchProxyScriptAdapterFetcher
+ : public MockDhcpProxyScriptAdapterFetcher {
+public:
+ MockDhcpRealFetchProxyScriptAdapterFetcher()
+ : MockDhcpProxyScriptAdapterFetcher(),
+ url_request_context_(new TestURLRequestContext()) {
+ }
+
+ // Returns a real proxy script fetcher.
+ ProxyScriptFetcher* ImplCreateScriptFetcher(const GURL& url) OVERRIDE {
+ URLProxyScriptFetcher* fetcher =
+ new ProxyScriptFetcherImpl(url_request_context_.get());
+ fetcher->SetURL(url);
+ return fetcher;
+ }
+
+ scoped_refptr<URLRequestContext> url_request_context_;
+};
+
+TEST(DhcpProxyScriptAdapterFetcher, MockDhcpRealFetch) {
+ TestServer test_server(
+ TestServer::TYPE_HTTP,
+ FilePath(FILE_PATH_LITERAL("net/data/proxy_script_fetcher_unittest")));
+ ASSERT_TRUE(test_server.Start());
+
+ GURL configured_url = test_server.GetURL("files/downloadable.pac");
+
+ FetcherClient client;
+ client.fetcher_ = new MockDhcpRealFetchProxyScriptAdapterFetcher();
+ client.fetcher_->configured_url_ = configured_url.spec();
+ client.RunTest();
+ client.RunMessageLoopUntilComplete();
+ ASSERT_TRUE(client.fetcher_->DidFinish());
+ EXPECT_EQ(OK, client.fetcher_->result());
+ EXPECT_EQ(string16(L"-downloadable.pac-\n"), client.fetcher_->pac_script());
+ EXPECT_EQ(configured_url,
+ client.fetcher_->pac_url());
+}
+
+} // namespace
+} // namespace net

Powered by Google App Engine
This is Rietveld 408576698