Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6831016: Profile shouldn't own background page stuff. (Closed)

Created:
9 years, 8 months ago by Torne
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Profile shouldn't own background page stuff. BackgroundContentsService and BackgroundModeManager now have factories which own them, using Profile as a key. This uses the ProfileKeyedService infrastructure. BUG=77155 TEST=existing tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -52 lines) Patch
M chrome/browser/background_contents_service.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/background_contents_service.cc View 3 chunks +5 lines, -3 lines 0 comments Download
A chrome/browser/background_contents_service_factory.h View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/background_contents_service_factory.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M chrome/browser/background_mode_manager.h View 2 chunks +3 lines, -1 line 0 comments Download
A chrome/browser/background_mode_manager_factory.h View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/background_mode_manager_factory.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/background_page_tracker.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_background_page_apitest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 4 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 4 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/testing_profile.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/testing_profile.cc View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Torne
9 years, 8 months ago (2011-04-14 15:50:16 UTC) #1
Elliot Glaysher
LGTM
9 years, 8 months ago (2011-04-14 17:29:19 UTC) #2
commit-bot: I haz the power
Try job failure for 6831016-1 on mac: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=22295
9 years, 8 months ago (2011-04-14 18:26:54 UTC) #3
commit-bot: I haz the power
9 years, 8 months ago (2011-04-15 10:18:47 UTC) #4 
Change committed as 81723

Powered by Google App Engine
This is Rietveld 408576698