Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 6826036: Bring test262 expectations up-to-date. (Closed)

Created:
9 years, 8 months ago by Martin Maly
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Bring test262 expectations up-to-date. Add missing *.js files into Xcode project. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7573

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -66 lines) Patch
M test/test262/harness-adapt.js View 1 2 chunks +8 lines, -6 lines 0 comments Download
M test/test262/test262.status View 2 chunks +14 lines, -60 lines 0 comments Download
M tools/v8.xcodeproj/project.pbxproj View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Martin Maly
9 years, 8 months ago (2011-04-11 13:08:15 UTC) #1
Mads Ager (chromium)
LGTM
9 years, 8 months ago (2011-04-11 13:10:41 UTC) #2
Rico
LGTM http://codereview.chromium.org/6826036/diff/1/test/test262/harness-adapt.js File test/test262/harness-adapt.js (right): http://codereview.chromium.org/6826036/diff/1/test/test262/harness-adapt.js#newcode55 test/test262/harness-adapt.js:55: res = 'fail'; error = e; Not from ...
9 years, 8 months ago (2011-04-11 13:16:35 UTC) #3
Martin Maly
9 years, 8 months ago (2011-04-11 13:54:46 UTC) #4
Thanks, landed after making the change.

http://codereview.chromium.org/6826036/diff/1/test/test262/harness-adapt.js
File test/test262/harness-adapt.js (right):

http://codereview.chromium.org/6826036/diff/1/test/test262/harness-adapt.js#n...
test/test262/harness-adapt.js:55: res = 'fail'; error = e;
On 2011/04/11 13:16:35, Rico wrote:
> Not from this cl, but put these on seperate lines

Done.

Powered by Google App Engine
This is Rietveld 408576698