Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6826032: Remove code from the deprecated GenericBinaryOpStub. (Closed)

Created:
9 years, 8 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove code from the deprecated GenericBinaryOpStub. All platforms are now using the TypeRecordingBinaryOpStub. I also removed the ARM IntegerModStub which was called from the GenericBinaryOpStub. Committed: http://code.google.com/p/v8/source/detail?r=7566

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3473 lines) Patch
src/arm/code-stubs-arm.h View 2 chunks +0 lines, -252 lines 0 comments Download
src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -1082 lines 0 comments Download
src/arm/lithium-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
src/code-stubs.h View 3 chunks +2 lines, -4 lines 0 comments Download
src/debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
src/ia32/code-stubs-ia32.h View 1 chunk +0 lines, -155 lines 0 comments Download
src/ia32/code-stubs-ia32.cc View 2 chunks +0 lines, -916 lines 0 comments Download
src/ic.h View 2 chunks +0 lines, -25 lines 0 comments Download
src/ic.cc View 2 chunks +0 lines, -142 lines 0 comments Download
src/log.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -1 line 0 comments Download
src/objects-inl.h View 3 chunks +0 lines, -14 lines 0 comments Download
M src/spaces.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.cc View 1 3 chunks +3 lines, -21 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 chunk +0 lines, -139 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +0 lines, -712 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 8 months ago (2011-04-11 09:18:32 UTC) #1
Søren Thygesen Gjesse
9 years, 8 months ago (2011-04-11 09:24:35 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698