Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 6826031: ARM: Fix wrong fall through handling (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 true, 424 true,
425 true_label_, 425 true_label_,
426 false_label_); 426 false_label_);
427 ASSERT(!lit->IsUndetectableObject()); // There are no undetectable literals. 427 ASSERT(!lit->IsUndetectableObject()); // There are no undetectable literals.
428 if (lit->IsUndefined() || lit->IsNull() || lit->IsFalse()) { 428 if (lit->IsUndefined() || lit->IsNull() || lit->IsFalse()) {
429 if (false_label_ != fall_through_) __ b(false_label_); 429 if (false_label_ != fall_through_) __ b(false_label_);
430 } else if (lit->IsTrue() || lit->IsJSObject()) { 430 } else if (lit->IsTrue() || lit->IsJSObject()) {
431 if (true_label_ != fall_through_) __ b(true_label_); 431 if (true_label_ != fall_through_) __ b(true_label_);
432 } else if (lit->IsString()) { 432 } else if (lit->IsString()) {
433 if (String::cast(*lit)->length() == 0) { 433 if (String::cast(*lit)->length() == 0) {
434 if (false_label_ != fall_through_) __ b(false_label_); 434 if (false_label_ != fall_through_) __ b(false_label_);
435 __ b(false_label_);
436 } else { 435 } else {
437 if (true_label_ != fall_through_) __ b(true_label_); 436 if (true_label_ != fall_through_) __ b(true_label_);
438 } 437 }
439 } else if (lit->IsSmi()) { 438 } else if (lit->IsSmi()) {
440 if (Smi::cast(*lit)->value() == 0) { 439 if (Smi::cast(*lit)->value() == 0) {
441 if (false_label_ != fall_through_) __ b(false_label_); 440 if (false_label_ != fall_through_) __ b(false_label_);
442 } else { 441 } else {
443 if (true_label_ != fall_through_) __ b(true_label_); 442 if (true_label_ != fall_through_) __ b(true_label_);
444 } 443 }
445 } else { 444 } else {
(...skipping 3919 matching lines...) Expand 10 before | Expand all | Expand 10 after
4365 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value. 4364 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value.
4366 __ add(pc, r1, Operand(masm_->CodeObject())); 4365 __ add(pc, r1, Operand(masm_->CodeObject()));
4367 } 4366 }
4368 4367
4369 4368
4370 #undef __ 4369 #undef __
4371 4370
4372 } } // namespace v8::internal 4371 } } // namespace v8::internal
4373 4372
4374 #endif // V8_TARGET_ARCH_ARM 4373 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698