Connect the right metafiles for print preview on Linux and Windows.

Connect the right metafiles for print preview on Linux and Windows. 

+ Remove the NativeMetafileFactory since we can't just use preview flag. 
+ Update each Metafile constructor site to use PreviewMetafile or NativeMetafileImpl. 
+ Fix misc. problems blocking pdf generation on Windows. 
+ Rename the metafile interface.

BUG=NONE
TEST=NONE

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81161

[Lei Zhang, 2011-04-11 02:51:10]

http://codereview.chromium.org/6826027/diff/2001/chrome/browser/printing/prin...
File chrome/browser/printing/print_view_manager.cc (right):

http://codereview.chromium.org/6826027/diff/2001/chrome/browser/printing/prin...
chrome/browser/printing/print_view_manager.cc:23: #include
"printing/metafile_impl.h"
you probably don't need both. metafile_impl.h will likely always include
metafile.h.

http://codereview.chromium.org/6826027/diff/2001/chrome/browser/printing/prin...
chrome/browser/printing/print_view_manager.cc:151:
metafile->InitFromData(shared_buf.memory(), params.data_size);
Need to check return value, and remove the if check below since it no longer
makes sense.

http://codereview.chromium.org/6826027/diff/2001/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper_mac.mm (right):

http://codereview.chromium.org/6826027/diff/2001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper_mac.mm:22: if(!metafile.Init())
if( -> if (

ditto below.

http://codereview.chromium.org/6826027/diff/2001/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper_win.cc (right):

http://codereview.chromium.org/6826027/diff/2001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper_win.cc:224: // PreviewMetafile (PDF)
supports alpha blend.
Err, PrintWebViewHelper::PrintPageInternal() also calls RenderPage(). In which
case we are not using a PreviewMetafile.

http://codereview.chromium.org/6826027/diff/2001/printing/image.h
File printing/image.h (right):

http://codereview.chromium.org/6826027/diff/2001/printing/image.h#newcode13
printing/image.h:13: #include "printing/metafile.h"
forward declare instead?

http://codereview.chromium.org/6826027/diff/2001/printing/printing_context_ca...
File printing/printing_context_cairo.h (right):

http://codereview.chromium.org/6826027/diff/2001/printing/printing_context_ca...
printing/printing_context_cairo.h:13: #include "printing/metafile.h"
forward declare?

[vandebo (ex-Chrome), 2011-04-11 06:16:07]

+jam for change in content/

http://codereview.chromium.org/6826027/diff/2001/chrome/browser/printing/prin...
File chrome/browser/printing/print_view_manager.cc (right):

http://codereview.chromium.org/6826027/diff/2001/chrome/browser/printing/prin...
chrome/browser/printing/print_view_manager.cc:23: #include
"printing/metafile_impl.h"
On 2011/04/11 02:51:10, Lei Zhang wrote:
> you probably don't need both. metafile_impl.h will likely always include
> metafile.h.

I agree that in this case we probably only need metafile_impl.h, but is there a
style rule that allows that violation of include what you use?  This file does
explicitly use the interface in metafile.h

http://codereview.chromium.org/6826027/diff/2001/chrome/browser/printing/prin...
chrome/browser/printing/print_view_manager.cc:151:
metafile->InitFromData(shared_buf.memory(), params.data_size);
On 2011/04/11 02:51:10, Lei Zhang wrote:
> Need to check return value, and remove the if check below since it no longer
> makes sense.

Done.

http://codereview.chromium.org/6826027/diff/2001/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper_mac.mm (right):

http://codereview.chromium.org/6826027/diff/2001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper_mac.mm:22: if(!metafile.Init())
On 2011/04/11 02:51:10, Lei Zhang wrote:
> if( -> if (
> 
> ditto below.

Done.

http://codereview.chromium.org/6826027/diff/2001/chrome/renderer/print_web_vi...
File chrome/renderer/print_web_view_helper_win.cc (right):

http://codereview.chromium.org/6826027/diff/2001/chrome/renderer/print_web_vi...
chrome/renderer/print_web_view_helper_win.cc:224: // PreviewMetafile (PDF)
supports alpha blend.
On 2011/04/11 02:51:10, Lei Zhang wrote:
> Err, PrintWebViewHelper::PrintPageInternal() also calls RenderPage(). In which
> case we are not using a PreviewMetafile.

Comment clarified.

http://codereview.chromium.org/6826027/diff/2001/printing/image.h
File printing/image.h (right):

http://codereview.chromium.org/6826027/diff/2001/printing/image.h#newcode13
printing/image.h:13: #include "printing/metafile.h"
On 2011/04/11 02:51:10, Lei Zhang wrote:
> forward declare instead?

Done.

http://codereview.chromium.org/6826027/diff/2001/printing/printing_context_ca...
File printing/printing_context_cairo.h (right):

http://codereview.chromium.org/6826027/diff/2001/printing/printing_context_ca...
printing/printing_context_cairo.h:13: #include "printing/metafile.h"
On 2011/04/11 02:51:10, Lei Zhang wrote:
> forward declare?

Done.

[Lei Zhang, 2011-04-11 06:37:09]

LGTM, but you probably have to rebase one more time because I modified
print_dialog_gtk.cc.

[vandebo (ex-Chrome), 2011-04-11 07:18:45]

On 2011/04/11 06:37:09, Lei Zhang wrote:
> LGTM, but you probably have to rebase one more time because I modified
> print_dialog_gtk.cc.

Indeed, rebased.

[jam, 2011-04-11 21:39:14]

content lgtm