Issue 6826015: Ensure URL is updated after a cross-site navigation is pre-empted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6826015: Ensure URL is updated after a cross-site navigation is pre-empted (Closed)

Created:
9 years, 8 months ago by Charlie Reis

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Ensure URL is updated after a cross-site navigation is pre-empted by an "ignored" navigation. BUG=77507 TEST=NavigationControllerTest.LoadURL_IgnorePreemptsPending Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81307

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -1 line)			Patch
	M	content/browser/tab_contents/navigation_controller.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download
	M	content/browser/tab_contents/navigation_controller_unittest.cc	View	1	2 chunks	+76 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Charlie Reis

Hey Brett-- Here's a starting point for trying to fix 77507. I'm not thrilled with ...

9 years, 8 months ago (2011-04-08 21:44:50 UTC) #1

Charlie Reis

On 2011/04/12 16:11:12, brettw wrote: > I think this is probably reasonable. LGTM Great, thanks! ...

9 years, 8 months ago (2011-04-12 18:25:05 UTC) #4

LGTM