Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 6825085: Add script to apply a patch from rietveld. (Closed)

Created:
9 years, 8 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Visibility:
Public.

Description

Add script to apply a patch from rietveld. At the moment it just fetches the patch. It's still useful to debug rietveld issues. Improve resiliency to invalid patches. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81305

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
A apply_issue.py View 1 chunk +62 lines, -0 lines 2 comments Download
M patch.py View 1 chunk +2 lines, -0 lines 0 comments Download
M rietveld.py View 3 chunks +5 lines, -2 lines 0 comments Download
M tests/patch_test.py View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
9 years, 8 months ago (2011-04-12 19:25:43 UTC) #1
Dirk Pranke
git-cl already has this logic. Perhaps it makes more sense to have this be a ...
9 years, 8 months ago (2011-04-12 20:44:28 UTC) #2
M-A Ruel
On 2011/04/12 20:44:28, Dirk Pranke wrote: > git-cl already has this logic. Perhaps it makes ...
9 years, 8 months ago (2011-04-12 20:45:20 UTC) #3
Dirk Pranke
LGTM. http://codereview.chromium.org/6825085/diff/1/apply_issue.py File apply_issue.py (right): http://codereview.chromium.org/6825085/diff/1/apply_issue.py#newcode23 apply_issue.py:23: '-i', '--issue', type='int', help='Rietveld issue number') Maybe this ...
9 years, 8 months ago (2011-04-12 20:52:12 UTC) #4
M-A Ruel
http://codereview.chromium.org/6825085/diff/1/apply_issue.py File apply_issue.py (right): http://codereview.chromium.org/6825085/diff/1/apply_issue.py#newcode23 apply_issue.py:23: '-i', '--issue', type='int', help='Rietveld issue number') On 2011/04/12 20:52:12, ...
9 years, 8 months ago (2011-04-12 20:58:23 UTC) #5
Dirk Pranke
9 years, 8 months ago (2011-04-12 20:59:54 UTC) #6
I'm not sure how it's stricter, but the changing build infrastructure
part makes sense.

On Tue, Apr 12, 2011 at 1:58 PM,  <maruel@chromium.org> wrote:
>
> http://codereview.chromium.org/6825085/diff/1/apply_issue.py
> File apply_issue.py (right):
>
> http://codereview.chromium.org/6825085/diff/1/apply_issue.py#newcode23
> apply_issue.py:23: '-i', '--issue', type='int', help='Rietveld issue
> number')
> On 2011/04/12 20:52:12, Dirk Pranke wrote:
>>
>> Maybe this should be a positional parameter instead of optional, since
>
> it's
>>
>> pretty much mandatory, right?
>
> Right. I've just set it this way since it's stricter and reduces
> potential issues from changing build infrastructure. It eases the
> upgrade path when necessary.
>
> http://codereview.chromium.org/6825085/
>

Powered by Google App Engine
This is Rietveld 408576698