Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 6825078: [Chrome OS] Add setting for enabling whitelisting to device policy proto (Closed)

Created:
9 years, 8 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
gfeher, Jakob Kummerow
CC:
chromium-reviews
Visibility:
Public.

Description

[Chrome OS] Add setting for enabling whitelisting to device policy proto Today, we allow users to specify a whitelist but not enforce it. I can see an argument for changing this semantic...but in M13 :-) Add a field to the device policy proto buffer so that we can avoid changing the UI right now. BUG=13230 TEST=build chrome R=jkummerow@chromium.org,gfeher@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81263

Patch Set 1 #

Total comments: 2

Patch Set 2 : change field numbers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M chrome/browser/policy/proto/chrome_device_policy.proto View 1 2 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Chris Masone
9 years, 8 months ago (2011-04-12 16:07:37 UTC) #1
gfeher
Sorry guys, I forgot to tell last time that field number 5 is already taken ...
9 years, 8 months ago (2011-04-12 16:18:29 UTC) #2
Chris Masone
http://codereview.chromium.org/6825078/diff/1/chrome/browser/policy/proto/chrome_device_policy.proto File chrome/browser/policy/proto/chrome_device_policy.proto (right): http://codereview.chromium.org/6825078/diff/1/chrome/browser/policy/proto/chrome_device_policy.proto#newcode42 chrome/browser/policy/proto/chrome_device_policy.proto:42: optional bool allow_new_users = 1; On 2011/04/12 16:18:29, gfeher ...
9 years, 8 months ago (2011-04-12 16:22:39 UTC) #3
gfeher
Thanks. LGTM
9 years, 8 months ago (2011-04-12 16:28:25 UTC) #4
Jakob Kummerow
9 years, 8 months ago (2011-04-12 16:36:20 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698