Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6825074: Adds method call to UpdatePrintableSizeInPrintParameters() to fix Content Area width on print on ... (Closed)

Created:
9 years, 8 months ago by clementskau
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Adds method call to UpdatePrintableSizeInPrintParameters() to fix Content Area width on print on Linux. This happens in connection with CSS3 Paged Media margins. BUG=79157 TEST=Try and print a page with CSS3 Paged Media margins like: http://dl.dropbox.com/u/599885/CSS3_Paged_Media_Margin_test.htm Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81355

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/print_web_view_helper_linux.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
clementskau
9 years, 8 months ago (2011-04-12 12:46:29 UTC) #1
tony
(adding people actually working on printing) http://codereview.chromium.org/6825074/diff/1/AUTHORS File AUTHORS (right): http://codereview.chromium.org/6825074/diff/1/AUTHORS#newcode5 AUTHORS:5: Clement Scheelfeldt Skau ...
9 years, 8 months ago (2011-04-12 17:54:01 UTC) #2
tony
Also, did you sign the CLA? http://code.google.com/legal/individual-cla-v1.0.html
9 years, 8 months ago (2011-04-12 17:54:27 UTC) #3
clementskau
> Please add your name to the end of the file. I'm assuming the other ...
9 years, 8 months ago (2011-04-12 18:31:29 UTC) #4
tony
On 2011/04/12 18:31:29, clementskau wrote: > Over at Go the list is sorted alphabetically, but ...
9 years, 8 months ago (2011-04-12 18:42:57 UTC) #5
clementskau
On 2011/04/12 18:42:57, tony wrote: > On 2011/04/12 18:31:29, clementskau wrote: > > Over at ...
9 years, 8 months ago (2011-04-12 18:46:18 UTC) #6
Lei Zhang
LGTM. Thanks for catching this. I assume I'll need to commit this for you?
9 years, 8 months ago (2011-04-12 22:49:21 UTC) #7
vandebo (ex-Chrome)
On 2011/04/12 22:49:21, Lei Zhang wrote: > LGTM. Thanks for catching this. I assume I'll ...
9 years, 8 months ago (2011-04-12 22:54:16 UTC) #8
Lei Zhang
On 2011/04/12 22:54:16, vandebo wrote: > On 2011/04/12 22:49:21, Lei Zhang wrote: > > LGTM. ...
9 years, 8 months ago (2011-04-12 23:50:11 UTC) #9
commit-bot: I haz the power
9 years, 8 months ago (2011-04-13 02:03:50 UTC) #10
Change committed as 81355

Powered by Google App Engine
This is Rietveld 408576698