Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 6825062: Fix bug where multiprocessing.Queue hangs on large outputs. (Closed)

Created:
9 years, 8 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
dgarrett
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Fix bug where multiprocessing.Queue hangs on large outputs. Change-Id: Ia504a0518f7550f764be9ff05bdbd7749d065c65 BUG=chromium-os:14055 TEST=Ran through with ctest and a mario build I built today! Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=09254c2

Patch Set 1 #

Patch Set 2 : Fix test #

Total comments: 6

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -44 lines) Patch
M au_test_harness/cros_au_test_harness.py View 1 2 7 chunks +45 lines, -36 lines 0 comments Download
M au_test_harness/parallel_test_job.py View 1 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sosa
9 years, 8 months ago (2011-04-12 01:07:16 UTC) #1
dgarrett
LGTM with some nits. The style comments are just about how I would do it. ...
9 years, 8 months ago (2011-04-12 02:01:52 UTC) #2
sosa
9 years, 8 months ago (2011-04-12 02:09:50 UTC) #3
http://codereview.chromium.org/6825062/diff/4/au_test_harness/cros_au_test_ha...
File au_test_harness/cros_au_test_harness.py (right):

http://codereview.chromium.org/6825062/diff/4/au_test_harness/cros_au_test_ha...
au_test_harness/cros_au_test_harness.py:83: return_codes):
On 2011/04/12 02:01:52, dgarrett wrote:
> off by one indention.

Done.

http://codereview.chromium.org/6825062/diff/4/au_test_harness/cros_au_test_ha...
au_test_harness/cros_au_test_harness.py:89: key_line_re =
re.compile('^PREGENERATED_UPDATE=([\w/.]+)')
On 2011/04/12 02:01:52, dgarrett wrote:
> Can do this outside the outer for loop and not regenerate for each file.

Done.

http://codereview.chromium.org/6825062/diff/4/au_test_harness/cros_au_test_ha...
au_test_harness/cros_au_test_harness.py:90: if return_code != 0:
I actually want to print out the output from a failed update (Warning(output))
so i need to get output first.

On 2011/04/12 02:01:52, dgarrett wrote:
> Seems like this line should be the first line after the for loop on line 82,
and
> that it doesn't need an else clause at all. Just unindent the normal case
code.

Powered by Google App Engine
This is Rietveld 408576698