Issue 6825061: Another attempt to fix Win build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6825061: Another attempt to fix Win build. (Closed)

Created:
9 years, 8 months ago by Dmitry Titov

Modified:
9 years, 8 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev, Dmitry Lomov

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Another attempt to fix Win build. Committed: http://code.google.com/p/v8/source/detail?r=7577

Patch Set 1 #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/platform-win32.cc	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

9 years, 8 months ago (2011-04-12 02:40:56 UTC) #2

http://codereview.chromium.org/6825061/diff/1/src/platform-win32.cc
File src/platform-win32.cc (right):

http://codereview.chromium.org/6825061/diff/1/src/platform-win32.cc#newcode1531
src/platform-win32.cc:1531: _beginthreadex(NULL,
Shouldn't we still assert thread creation succeeded?

Expand Messages | Collapse Messages