Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: chrome/browser/resources/new_new_tab.js

Issue 6825052: Update the web store promo to be clearer and configurable at run-time. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix URL. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // To avoid creating tons of unnecessary nodes. We assume we cannot fit more 5 // To avoid creating tons of unnecessary nodes. We assume we cannot fit more
6 // than this many items in the miniview. 6 // than this many items in the miniview.
7 var MAX_MINIVIEW_ITEMS = 15; 7 var MAX_MINIVIEW_ITEMS = 15;
8 8
9 // Extra spacing at the top of the layout. 9 // Extra spacing at the top of the layout.
10 var LAYOUT_SPACING_TOP = 25; 10 var LAYOUT_SPACING_TOP = 25;
(...skipping 1449 matching lines...) Expand 10 before | Expand all | Expand 10 after
1460 1460
1461 function maybeDoneLoading() { 1461 function maybeDoneLoading() {
1462 if (mostVisited.data && apps.loaded) 1462 if (mostVisited.data && apps.loaded)
1463 document.body.classList.remove('loading'); 1463 document.body.classList.remove('loading');
1464 } 1464 }
1465 1465
1466 function isDoneLoading() { 1466 function isDoneLoading() {
1467 return !document.body.classList.contains('loading'); 1467 return !document.body.classList.contains('loading');
1468 } 1468 }
1469 1469
1470 // Initialize the apps promo. 1470 // Initialize the apps promo.
Miranda Callahan 2011/04/13 14:29:29 should this comment change now as well?
jstritar 2011/04/13 19:52:27 Done.
1471 document.addEventListener('DOMContentLoaded', function() { 1471 document.addEventListener('DOMContentLoaded', function() {
1472 var promoLink = document.querySelector('#apps-promo-text1 a');
1473 promoLink.id = 'apps-promo-link';
1474 promoLink.href = localStrings.getString('web_store_url');
1475
1476 $('apps-promo-hide').addEventListener('click', function() { 1472 $('apps-promo-hide').addEventListener('click', function() {
1477 chrome.send('hideAppsPromo', []); 1473 chrome.send('hideAppsPromo', []);
1478 document.documentElement.classList.remove('apps-promo-visible'); 1474 document.documentElement.classList.remove('apps-promo-visible');
1479 layoutSections(); 1475 layoutSections();
1480 }); 1476 });
1481 }); 1477 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698