Issue 6825049: Moving JavaScript code from i18n-extension.cc into i18n.js file using

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6825049: Moving JavaScript code from i18n-extension.cc into i18n.js file using (Closed)

Created:
9 years, 8 months ago by Nebojša Ćirić

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev, jungshik at Google

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Moving JavaScript code from i18n-extension.cc into i18n.js file using tools/js2c.py script. Added new type I18N to natives.h enum. Committed: http://code.google.com/p/v8/source/detail?r=7591

Patch Set 1 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -70 lines)			Patch
M	src/extensions/experimental/experimental.gyp	View	2 chunks	+32 lines, -0 lines	0 comments	Download
A	src/extensions/experimental/i18n.js	View	1 chunk	+103 lines, -0 lines	0 comments	Download
M	src/extensions/experimental/i18n-extension.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/extensions/experimental/i18n-extension.cc	View	2 chunks	+14 lines, -67 lines	0 comments	Download
M	src/natives.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nebojša Ćirić

We have to move JavaScript code from cc file since it's becoming increasingly harder to ...

9 years, 8 months ago (2011-04-11 20:51:08 UTC) #1

Mads Ager (chromium)

9 years, 8 months ago (2011-04-12 10:54:59 UTC) #2

LGTM

Splitting the enum at this point does not seem important to me. If more
experimental things like this gets added it might be a good idea to clean it up
at that point.

Expand Messages | Collapse Messages