Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 6825047: Add Mario support for fwupdate_tries (Closed)

Created:
9 years, 8 months ago by Randall Spangler
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add Mario support for fwupdate_tries Change-Id: I1c4240ebe5783ca923c310061e2a76947aa6601b R=reinauer@chromium.org BUG=chromium-os:14030 TEST=manual On a Mario: crossystem fwupdate_tries=3 crossystem fwupdate_tries # should be 3 cat /mnt/stateful_partition/.need_firmware_update # should be 3 crossystem fwupdate_tries=0 crossystem fwupdate_tries # should be 0 cat /mnt/stateful_partition/.need_firmware_update # should complain file doesn't exist On a newer platform: crossystem fwupdate_tries=3 crossystem fwupdate_tries # should be 3 cat /mnt/stateful_partition/.need_firmware_update # should complain file doesn't exist crossystem fwupdate_tries=0 crossystem fwupdate_tries # should be 0 cat /mnt/stateful_partition/.need_firmware_update # should complain file doesn't exist Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=07f3484

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixes from code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M host/arch/x86/lib/crossystem_arch.c View 1 3 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Randall Spangler
9 years, 8 months ago (2011-04-11 20:27:05 UTC) #1
Stefan Reinauer
Otherwise LGTM http://codereview.chromium.org/6825047/diff/1/host/arch/x86/lib/crossystem_arch.c File host/arch/x86/lib/crossystem_arch.c (right): http://codereview.chromium.org/6825047/diff/1/host/arch/x86/lib/crossystem_arch.c#newcode87 host/arch/x86/lib/crossystem_arch.c:87: /* Filename for legace firmware update tries ...
9 years, 8 months ago (2011-04-11 20:32:55 UTC) #2
Stefan Reinauer
9 years, 8 months ago (2011-04-11 20:35:08 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698