Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 6825042: Change the list of statements that are inlineable into a black-list. (Closed)

Created:
9 years, 8 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change the list of statements that are inlineable into a black-list. Before we had a white-list of things that we allow inside inlined functions. This way we can enable new constructs one-by-one. Committed: http://code.google.com/p/v8/source/detail?r=7585

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -5 lines) Patch
M src/ast.h View 1 27 chunks +28 lines, -3 lines 0 comments Download
M src/ast.cc View 1 2 chunks +135 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 8 months ago (2011-04-11 15:52:30 UTC) #1
Kevin Millikin (Chromium)
9 years, 8 months ago (2011-04-12 07:23:00 UTC) #2
LGTM.

http://codereview.chromium.org/6825042/diff/1/src/ast.cc
File src/ast.cc (right):

http://codereview.chromium.org/6825042/diff/1/src/ast.cc#newcode379
src/ast.cc:379: return false;
It won't stay sorted, but I think it's easiest to have all the blacklisted AST
types listed first and together, maybe even with a comment listing what they
are.

Powered by Google App Engine
This is Rietveld 408576698