Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 6825018: Linux: Fix a bug in upstream xdg-utils that breaks xdg-settings. (Closed)

Created:
9 years, 8 months ago by Mike Mammarella
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: Fix a bug in upstream xdg-utils that breaks xdg-settings. BUG=73231 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M scripts/xdg-desktop-icon View 1 chunk +1 line, -1 line 0 comments Download
M scripts/xdg-desktop-menu View 1 chunk +1 line, -1 line 0 comments Download
M scripts/xdg-email View 1 chunk +1 line, -1 line 0 comments Download
M scripts/xdg-icon-resource View 1 chunk +1 line, -1 line 0 comments Download
M scripts/xdg-mime View 1 chunk +1 line, -1 line 0 comments Download
M scripts/xdg-open View 1 chunk +1 line, -1 line 0 comments Download
M scripts/xdg-screensaver View 1 chunk +1 line, -1 line 0 comments Download
M scripts/xdg-settings View 1 chunk +1 line, -1 line 0 comments Download
M scripts/xdg-utils-common.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Mammarella
9 years, 8 months ago (2011-04-09 00:00:34 UTC) #1
Lei Zhang
This is for http://crbug.com/73231 ? I don't see how this helps. Redirecting stdout to /dev/null ...
9 years, 8 months ago (2011-04-09 00:17:55 UTC) #2
Mike Mammarella
On 2011/04/09 00:17:55, Lei Zhang wrote: > This is for http://crbug.com/73231 > ? > > ...
9 years, 8 months ago (2011-04-09 00:42:04 UTC) #3
Lei Zhang
9 years, 8 months ago (2011-04-09 00:48:32 UTC) #4
On 2011/04/09 00:42:04, Mike Mammarella wrote:
> On 2011/04/09 00:17:55, Lei Zhang wrote:
> > This is for http://crbug.com/73231
> > ?
> > 
> > I don't see how this helps. Redirecting stdout to /dev/null doesn't change
> > whether or not we set $DE.
> 
> On gnome 2, where we do have this binary, running "which" prints the path to
the
> binary, which interferes with all sorts of other stuff. We need to get no
output
> in order for the other things to work correctly.
> 
> This is only part of the fix for that bug. I'll add the BUG= line above
though.
> (The other half I'll send soon.)

Ah, so you are getting extra output in the output from xdg-settings. Ok.

LGTM

Powered by Google App Engine
This is Rietveld 408576698