Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 6824082: Populate disk information from udev to disk manager. (Closed)

Created:
9 years, 8 months ago by Ben Chan
Modified:
9 years, 7 months ago
Reviewers:
rtc
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Populate disk information from udev to disk manager. BUG=chromium-os:13698 TEST=Built and manually tested udev code. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=24ea839

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed issues after code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -2 lines) Patch
M disk-manager.cc View 1 2 chunks +34 lines, -2 lines 0 comments Download
A udev-device.h View 1 1 chunk +70 lines, -0 lines 0 comments Download
A udev-device.cc View 1 1 chunk +158 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ben Chan
9 years, 8 months ago (2011-04-12 19:51:49 UTC) #1
rtc
http://codereview.chromium.org/6824082/diff/1/disk-manager.cc File disk-manager.cc (right): http://codereview.chromium.org/6824082/diff/1/disk-manager.cc#newcode35 disk-manager.cc:35: struct udev *udev = udev_new(); There should be a ...
9 years, 8 months ago (2011-04-12 21:08:51 UTC) #2
rtc
http://codereview.chromium.org/6824082/diff/1/udev-device.cc File udev-device.cc (right): http://codereview.chromium.org/6824082/diff/1/udev-device.cc#newcode106 udev-device.cc:106: std::vector<std::string> UdevDevice::GetMountedPaths() const { It might be good to ...
9 years, 8 months ago (2011-04-12 21:12:01 UTC) #3
Ben Chan
http://codereview.chromium.org/6824082/diff/1/udev-device.cc File udev-device.cc (right): http://codereview.chromium.org/6824082/diff/1/udev-device.cc#newcode106 udev-device.cc:106: std::vector<std::string> UdevDevice::GetMountedPaths() const { On 2011/04/12 21:12:01, rtc wrote: ...
9 years, 8 months ago (2011-04-12 21:18:44 UTC) #4
Ben Chan
http://codereview.chromium.org/6824082/diff/1/disk-manager.cc File disk-manager.cc (right): http://codereview.chromium.org/6824082/diff/1/disk-manager.cc#newcode35 disk-manager.cc:35: struct udev *udev = udev_new(); On 2011/04/12 21:08:51, rtc ...
9 years, 8 months ago (2011-04-12 22:20:36 UTC) #5
rtc
LGTM
9 years, 8 months ago (2011-04-12 22:44:03 UTC) #6
Ben Chan
9 years, 8 months ago (2011-04-12 22:51:13 UTC) #7

          

Powered by Google App Engine
This is Rietveld 408576698