Populate disk information from udev to disk manager.

Populate disk information from udev to disk manager.


BUG=chromium-os:13698
TEST=Built and manually tested udev code.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=24ea839

[rtc, 2011-04-12 21:08:51]

http://codereview.chromium.org/6824082/diff/1/disk-manager.cc
File disk-manager.cc (right):

http://codereview.chromium.org/6824082/diff/1/disk-manager.cc#newcode35
disk-manager.cc:35: struct udev *udev = udev_new();
There should be a udev instance already created by the constructor. It's called
udev_

[rtc, 2011-04-12 21:12:01]

http://codereview.chromium.org/6824082/diff/1/udev-device.cc
File udev-device.cc (right):

http://codereview.chromium.org/6824082/diff/1/udev-device.cc#newcode106
udev-device.cc:106: std::vector<std::string> UdevDevice::GetMountedPaths() const
{
It might be good to pass data into the function so that the parsing could be
tested easily in a unit-test.

http://codereview.chromium.org/6824082/diff/1/udev-device.h
File udev-device.h (right):

http://codereview.chromium.org/6824082/diff/1/udev-device.h#newcode59
udev-device.h:59: mutable struct udev_device *dev_;
Can this be const?

[Ben Chan, 2011-04-12 21:18:44]

http://codereview.chromium.org/6824082/diff/1/udev-device.cc
File udev-device.cc (right):

http://codereview.chromium.org/6824082/diff/1/udev-device.cc#newcode106
udev-device.cc:106: std::vector<std::string> UdevDevice::GetMountedPaths() const
{
On 2011/04/12 21:12:01, rtc wrote:
> It might be good to pass data into the function so that the parsing could be
> tested easily in a unit-test. 

How about splitting the function into two?

std::vector<std::string> UdevDevice::ParseMountedPaths(std::istream& stream)
const;

std::vector<std::string> UdevDevice::GetMountedPaths() const {
  std::ifstream fs("/proc/mounts");
  ...
  return ParseMountedPaths(fs);
}

http://codereview.chromium.org/6824082/diff/1/udev-device.h
File udev-device.h (right):

http://codereview.chromium.org/6824082/diff/1/udev-device.h#newcode59
udev-device.h:59: mutable struct udev_device *dev_;
On 2011/04/12 21:12:01, rtc wrote:
> Can this be const?

Unfortunately, all udev_device_* function takes a (struct udev_device *), which
is not const

[Ben Chan, 2011-04-12 22:20:36]

http://codereview.chromium.org/6824082/diff/1/disk-manager.cc
File disk-manager.cc (right):

http://codereview.chromium.org/6824082/diff/1/disk-manager.cc#newcode35
disk-manager.cc:35: struct udev *udev = udev_new();
On 2011/04/12 21:08:51, rtc wrote:
> There should be a udev instance already created by the constructor. It's
called
> udev_

Done.

[rtc, 2011-04-12 22:44:03]

LGTM