Cleanup of ScannerConstants, now named UnicodeCache.

Cleanup of ScannerConstants, now named UnicodeCache.

The ScannerConstants class was originally static fields on the scanner class.
During creation of the stand-alone preparser and later isolates, it has been
moved into a separate class with a per-isolate instance.
It is used to hold caching unicode Predicate values.

This change renames the class to UnicodeCache, and passes a reference
to the instance down to methods that doesn't have an easy access to
an isolate (to avoid, e.g., having to do an Isolate::Current() for every
number parsed).

Committed: http://code.google.com/p/v8/source/detail?r=7584

[Karl Klose, 2011-04-12 07:55:39]

LGTM with comments.

The UnicodeCache parameter is used in different positions; in some function it
is the first argument, in others the last. You could consider to unify these.

http://codereview.chromium.org/6824071/diff/1/src/conversions.cc
File src/conversions.cc (right):

http://codereview.chromium.org/6824071/diff/1/src/conversions.cc#newcode1
src/conversions.cc:1: // Copyright 2006-2008 the V8 project authors. All rights
reserved.
Please update to 2011.

http://codereview.chromium.org/6824071/diff/1/src/conversions.h
File src/conversions.h (right):

http://codereview.chromium.org/6824071/diff/1/src/conversions.h#newcode1
src/conversions.h:1: // Copyright 2006-2008 the V8 project authors. All rights
reserved.
Please update to 2011.

http://codereview.chromium.org/6824071/diff/1/src/dateparser-inl.h
File src/dateparser-inl.h (right):

http://codereview.chromium.org/6824071/diff/1/src/dateparser-inl.h#newcode1
src/dateparser-inl.h:1: // Copyright 2008 the V8 project authors. All rights
reserved.
Please update to 2011.

http://codereview.chromium.org/6824071/diff/1/src/dateparser.h
File src/dateparser.h (right):

http://codereview.chromium.org/6824071/diff/1/src/dateparser.h#newcode1
src/dateparser.h:1: // Copyright 2008 the V8 project authors. All rights
reserved.
Please update to 2011.

http://codereview.chromium.org/6824071/diff/1/src/dateparser.h#newcode70
src/dateparser.h:70: explicit InputReader(UnicodeCache* unicode_cache,
Vector<Char> s)
Explicit is no longer needed here.

http://codereview.chromium.org/6824071/diff/1/src/isolate.cc
File src/isolate.cc (right):

http://codereview.chromium.org/6824071/diff/1/src/isolate.cc#newcode1
src/isolate.cc:1: // Copyright 2006-2010 the V8 project authors. All rights
reserved.
Please update to 2011.

http://codereview.chromium.org/6824071/diff/1/src/isolate.h
File src/isolate.h (right):

http://codereview.chromium.org/6824071/diff/1/src/isolate.h#newcode1
src/isolate.h:1: // Copyright 2010 the V8 project authors. All rights reserved.
Please update to 2011.

http://codereview.chromium.org/6824071/diff/1/src/preparser-api.cc
File src/preparser-api.cc (right):

http://codereview.chromium.org/6824071/diff/1/src/preparser-api.cc#newcode1
src/preparser-api.cc:1: // Copyright 2010 the V8 project authors. All rights
reserved.
Please update to 2011.

http://codereview.chromium.org/6824071/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6824071/diff/1/src/runtime.cc#newcode1
src/runtime.cc:1: // Copyright 2010 the V8 project authors. All rights reserved.
Please update to 2011.

http://codereview.chromium.org/6824071/diff/1/src/scanner-base.cc
File src/scanner-base.cc (right):

http://codereview.chromium.org/6824071/diff/1/src/scanner-base.cc#newcode42
src/scanner-base.cc:42: octal_pos_(kNoOctalLocation) {
I think this newline should be removed.

http://codereview.chromium.org/6824071/diff/1/src/scanner.cc
File src/scanner.cc (right):

http://codereview.chromium.org/6824071/diff/1/src/scanner.cc#newcode1
src/scanner.cc:1: // Copyright 2010 the V8 project authors. All rights reserved.
Please update to 2011.

http://codereview.chromium.org/6824071/diff/1/src/scanner.h
File src/scanner.h (right):

http://codereview.chromium.org/6824071/diff/1/src/scanner.h#newcode1
src/scanner.h:1: // Copyright 2010 the V8 project authors. All rights reserved.
Please update to 2011.

http://codereview.chromium.org/6824071/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

http://codereview.chromium.org/6824071/diff/1/test/cctest/test-parsing.cc#new...
test/cctest/test-parsing.cc:1: // Copyright 2006-2009 the V8 project authors.
All rights reserved.
Please update to 2011.

http://codereview.chromium.org/6824071/diff/1/test/cctest/test-parsing.cc#new...
test/cctest/test-parsing.cc:268: i::V8JavaScriptScanner
scanner(ISOLATE->unicode_cache());
You could cache the isolate* here.

http://codereview.chromium.org/6824071/diff/1/test/cctest/test-parsing.cc#new...
test/cctest/test-parsing.cc:361: i::V8JavaScriptScanner
scanner(ISOLATE->unicode_cache());
Ditto.

[Lasse Reichstein, 2011-04-12 08:18:47]

Update all years.

http://codereview.chromium.org/6824071/diff/1/src/dateparser.h
File src/dateparser.h (right):

http://codereview.chromium.org/6824071/diff/1/src/dateparser.h#newcode70
src/dateparser.h:70: explicit InputReader(UnicodeCache* unicode_cache,
Vector<Char> s)
Removed.

http://codereview.chromium.org/6824071/diff/1/src/scanner-base.cc
File src/scanner-base.cc (right):

http://codereview.chromium.org/6824071/diff/1/src/scanner-base.cc#newcode42
src/scanner-base.cc:42: octal_pos_(kNoOctalLocation) {
Done.

http://codereview.chromium.org/6824071/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

http://codereview.chromium.org/6824071/diff/1/test/cctest/test-parsing.cc#new...
test/cctest/test-parsing.cc:268: i::V8JavaScriptScanner
scanner(ISOLATE->unicode_cache());
I've removed the ISOLATE macro everywhere, but just by replacing it with
i::Isolate::Current(). Let's not optimize our test-cases prematurely.