PrerenderContents uses RESOURCE_RECEIVED_REDIRECT notification.

chrome/browser/prerender/prerender_contents.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prerender/prerender_contents.h"
 
 #include "base/process_util.h"
 #include "base/task.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/background_contents_service.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/prerender/prerender_final_status.h"
 #include "chrome/browser/prerender/prerender_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/renderer_preferences_util.h"
 #include "chrome/browser/ui/login/login_prompt.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/common/view_types.h"
 #include "content/browser/browsing_instance.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/renderer_host/resource_dispatcher_host.h"
+#include "content/browser/renderer_host/resource_request_details.h"
 #include "content/browser/site_instance.h"
 #include "content/common/notification_service.h"
 #include "content/common/view_messages.h"
 #include "ui/gfx/rect.h"
 
 #if defined(OS_MACOSX)
 #include "chrome/browser/mach_broker_mac.h"
 #endif
 
 namespace prerender {
@@ skipping 96 matching lines @@
   registrar_.Add(this, NotificationType::AUTH_NEEDED,
                  NotificationService::AllSources());
 
   registrar_.Add(this, NotificationType::AUTH_CANCELLED,
                  NotificationService::AllSources());
 
   // Register all responses to see if we should cancel.
   registrar_.Add(this, NotificationType::DOWNLOAD_INITIATED,
                  NotificationService::AllSources());
 
+  // Register for redirects.

[Charlie Reis, 2011/04/11 21:15:52]

Please add "from this RenderViewHostDelegate," since that's useful for
understanding why this is correct.

[cbentzel, 2011/04/12 18:07:59]

Done.

+  registrar_.Add(this, NotificationType::RESOURCE_RECEIVED_REDIRECT,
+                 Source<RenderViewHostDelegate>(this));
+
   DCHECK(load_start_time_.is_null());
   load_start_time_ = base::TimeTicks::Now();
 
   ViewMsg_Navigate_Params params;
   params.page_id = -1;
   params.pending_history_list_offset = -1;
   params.current_history_list_offset = -1;
   params.current_history_list_length = 0;
   params.url = prerender_url_;
   params.transition = PageTransition::LINK;
@@ skipping 164 matching lines @@
       DCHECK(NotificationService::NoDetails() == details);
       RenderViewHost* rvh = Source<RenderViewHost>(source).ptr();
       CHECK(rvh != NULL);
       if (rvh->delegate() == this) {
         Destroy(FINAL_STATUS_DOWNLOAD);
         return;
       }
       break;
     }
 
+    case NotificationType::RESOURCE_RECEIVED_REDIRECT: {
+      // RESOURCE_RECEIVED_REDIRECT can come for any resource on a page.
+      // If it's a redirect on the top-level resource, the name needs
+      // to be remembered for future matching, and if it redirects to
+      // an https resource, it needs to be canceled. If a subresource
+      // is redirected, nothing changes.

[Charlie Reis, 2011/04/11 21:15:52]

How are you distinguishing whether it's top-level or a sub-resource?  It's
possible for the same URL to be used for both.  Should you be checking
details->resource_type()?

[cbentzel, 2011/04/11 21:18:35]

I'll change to resource_type(). This was using "MatchesURL" to see if the
previous URL is one of the previously seen URL in the top level page.

[cbentzel, 2011/04/12 18:07:59]

resource_type() is much clearer about what's going on than MatchesURL [and
potentially a little faster].

+      DCHECK(Source<RenderViewHostDelegate>(source).ptr() == this);
+      ResourceRedirectDetails* resource_redirect_details =
+          Details<ResourceRedirectDetails>(details).ptr();
+      CHECK(resource_redirect_details != NULL);

[Charlie Reis, 2011/04/11 21:15:52]

I think Chrome style is to omit the "!= NULL".

[cbentzel, 2011/04/12 18:07:59]

Done.

+      if (MatchesURL(resource_redirect_details->url())) {
+        if (!AddAliasURL(resource_redirect_details->new_url()))
+          Destroy(FINAL_STATUS_HTTPS);
+      }
+      break;
+    }
+
     default:
       NOTREACHED() << "Unexpected notification sent.";
       break;
   }
 }
 
 void PrerenderContents::OnMessageBoxClosed(IPC::Message* reply_msg,
                                            bool success,
                                            const std::wstring& prompt) {
   render_view_host_->JavaScriptMessageBoxClosed(reply_msg, success, prompt);
@@ skipping 70 matching lines @@
 void PrerenderContents::ShowCreatedFullscreenWidget(int route_id) {
   NOTIMPLEMENTED();
 }
 
 bool PrerenderContents::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   bool message_is_ok = true;
   IPC_BEGIN_MESSAGE_MAP_EX(PrerenderContents, message, message_is_ok)
     IPC_MESSAGE_HANDLER(ViewHostMsg_DidStartProvisionalLoadForFrame,
                         OnDidStartProvisionalLoadForFrame)
-    IPC_MESSAGE_HANDLER(ViewHostMsg_DidRedirectProvisionalLoad,
-                        OnDidRedirectProvisionalLoad)
     IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateFaviconURL, OnUpdateFaviconURL)
     IPC_MESSAGE_HANDLER(ViewHostMsg_MaybeCancelPrerender,
                         OnMaybeCancelPrerender)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP_EX()
 
   return handled;
 }
 
 void PrerenderContents::OnDidStartProvisionalLoadForFrame(int64 frame_id,
                                                           bool is_main_frame,
                                                           const GURL& url) {
   if (is_main_frame) {
     if (!AddAliasURL(url)) {
       Destroy(FINAL_STATUS_HTTPS);
       return;
     }
 
     // Usually, this event fires if the user clicks or enters a new URL.
     // Neither of these can happen in the case of an invisible prerender.
     // So the cause is: Some JavaScript caused a new URL to be loaded.  In that
     // case, the spinner would start again in the browser, so we must reset
     // has_stopped_loading_ so that the spinner won't be stopped.
     has_stopped_loading_ = false;
   }
 }
 
-void PrerenderContents::OnDidRedirectProvisionalLoad(int32 page_id,
-                                                     const GURL& source_url,
-                                                     const GURL& target_url) {
-  if (!AddAliasURL(target_url))
-    Destroy(FINAL_STATUS_HTTPS);
-}
-
 void PrerenderContents::OnUpdateFaviconURL(int32 page_id,
                                            const GURL& icon_url) {
   icon_url_ = icon_url;
 }
 
 void PrerenderContents::OnMaybeCancelPrerender(
     PrerenderCancellationReason reason) {
   switch (reason) {
     case PRERENDER_CANCELLATION_REASON_HTML5_MEDIA:
       Destroy(FINAL_STATUS_HTML5_MEDIA);
@@ skipping 62 matching lines @@
     return;
 
   size_t private_bytes, shared_bytes;
   if (metrics->GetMemoryBytes(&private_bytes, &shared_bytes)) {
     if (private_bytes > kMaxPrerenderPrivateMB * 1024 * 1024)
       Destroy(FINAL_STATUS_MEMORY_LIMIT_EXCEEDED);
   }
 }
 
 }  // namespace prerender