Issue 6824047: Test for disabling while connecting.

Issue 6824047: Test for disabling while connecting. (Closed)

Created:
9 years, 8 months ago by rochberg

Modified:
9 years, 7 months ago

Reviewers:
Jason Glasgow

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

Test for disabling while connecting. BUG=chromium-os:9571 Change-Id: I5f281053a7266d583994a2f588c23ea6ca9029d0 R=jglasgow@chromium.org TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=41de5f2

Patch Set 2 : Back out debug printfs #

Total comments: 4

Patch Set 3 : Code review comments #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -0 lines)			Patch
	A	client/site_tests/network_3GDisableWhileConnecting/control	View		1 chunk	+54 lines, -0 lines	0 comments	Download
	A	client/site_tests/network_3GDisableWhileConnecting/network_3GDisableWhileConnecting.py	View	1 2	1 chunk	+181 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jason Glasgow

LGTM http://codereview.chromium.org/6824047/diff/3001/client/site_tests/network_3GDisableWhileConnecting/network_3GDisableWhileConnecting.py File client/site_tests/network_3GDisableWhileConnecting/network_3GDisableWhileConnecting.py (right): http://codereview.chromium.org/6824047/diff/3001/client/site_tests/network_3GDisableWhileConnecting/network_3GDisableWhileConnecting.py#newcode88 client/site_tests/network_3GDisableWhileConnecting/network_3GDisableWhileConnecting.py:88: self.remaining_requirements = set(['connect','disable', 'get_status']) space after 'connect', http://codereview.chromium.org/6824047/diff/3001/client/site_tests/network_3GDisableWhileConnecting/network_3GDisableWhileConnecting.py#newcode129 ...

9 years, 8 months ago (2011-04-11 19:33:22 UTC) #2

rochberg

9 years, 8 months ago (2011-04-11 19:38:23 UTC) #3

http://codereview.chromium.org/6824047/diff/3001/client/site_tests/network_3G...
File
client/site_tests/network_3GDisableWhileConnecting/network_3GDisableWhileConnecting.py
(right):

http://codereview.chromium.org/6824047/diff/3001/client/site_tests/network_3G...
client/site_tests/network_3GDisableWhileConnecting/network_3GDisableWhileConnecting.py:88:
self.remaining_requirements = set(['connect','disable', 'get_status'])
On 2011/04/11 19:33:22, Jason Glasgow wrote:
> space after 'connect',

Done.

http://codereview.chromium.org/6824047/diff/3001/client/site_tests/network_3G...
client/site_tests/network_3GDisableWhileConnecting/network_3GDisableWhileConnecting.py:129:

On 2011/04/11 19:33:22, Jason Glasgow wrote:
> extra line

Done.

Expand Messages | Collapse Messages