Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3285)

Unified Diff: drivers/usb/class/cdc-acm.c

Issue 6824041: USB: cdc-acm: fix deadlock in acm_tty_open (Closed)
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: drivers/usb/class/cdc-acm.c
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index fc74de7455578d49ccccb21300e64a370641a3a4..a98e388933401e583fac1537b0286e0bfee5e104 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -587,8 +587,6 @@ static int acm_tty_open(struct tty_struct *tty, struct file *filp)
(acm->ctrl_caps & USB_CDC_CAP_LINE))
goto full_bailout;
- usb_autopm_put_interface(acm->control);
-
INIT_LIST_HEAD(&acm->spare_read_urbs);
INIT_LIST_HEAD(&acm->spare_read_bufs);
INIT_LIST_HEAD(&acm->filled_read_bufs);
@@ -605,6 +603,7 @@ static int acm_tty_open(struct tty_struct *tty, struct file *filp)
tasklet_schedule(&acm->urb_task);
mutex_unlock(&acm->mutex);
+ usb_autopm_put_interface(acm->control);
out:
mutex_unlock(&open_mutex);
return rv;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698