Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 6824032: First batch of cros-disk changes (Closed)

Created:
9 years, 8 months ago by rtc
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

First batch of cros-disk changes A couple of things in this CL. 1. Adds an upstart script that runs the daemon as cros-disks. 2. Adds some functions to the d-bus API. 3. Adds support for watching udev for changes. 4. Adds a DiskManager class for processing disk changes. 5. Adds a Disk class to store the properties that we care about. 6. Some Makefile changes to fix NDEBUG and gflags issues. Change-Id: I92f7d9199b71aa0150ad82cabe36c5396a4603c8 BUG=13698 TEST=Ran the autotest and manually tested that I was getting udev changes on a cr-48. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c523a85

Patch Set 1 #

Total comments: 2

Patch Set 2 : adds set_ and removes j's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+504 lines, -9 lines) Patch
M Makefile View 1 chunk +12 lines, -3 lines 0 comments Download
M common.mk View 1 chunk +4 lines, -4 lines 0 comments Download
A cros-disks.conf View 1 chunk +23 lines, -0 lines 0 comments Download
A cros-disks.xml View 1 chunk +43 lines, -0 lines 0 comments Download
A cros-disks-server-impl.h View 1 chunk +50 lines, -0 lines 0 comments Download
A cros-disks-server-impl.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A disk.h View 1 1 chunk +106 lines, -0 lines 0 comments Download
A disk.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A disk-manager.h View 1 chunk +56 lines, -0 lines 0 comments Download
A disk-manager.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M main.cc View 1 2 chunks +68 lines, -2 lines 0 comments Download
A org.chromium.CrosDisks.conf View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rtc
9 years, 8 months ago (2011-04-11 02:30:39 UTC) #1
Chris Masone
9 years, 8 months ago (2011-04-11 02:50:45 UTC) #2
LGTM w/nits, also remove jjjjjjjjjj in main.cc

http://codereview.chromium.org/6824032/diff/1/disk.h
File disk.h (right):

http://codereview.chromium.org/6824032/diff/1/disk.h#newcode30
disk.h:30: void is_drive(bool is_drive) { is_drive_ = is_drive; }
Setters should start with set_

http://codereview.chromium.org/6824032/diff/1/disk.h#newcode54
disk.h:54: std::string mount_path() const { return mount_path_; }
const std::string&

Powered by Google App Engine
This is Rietveld 408576698