Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: builder.py

Issue 6824021: Add features flag to gmerge. (Closed) Base URL: http://git.chromium.org/git/dev-util.git@master
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gmerge » ('j') | gmerge » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: builder.py
diff --git a/builder.py b/builder.py
index bf83c3e7f82462f240e23e8b5ee52262e1c39afd..3553a6b89a6afc2e0b7c220b89def7f37c4ac8db 100644
--- a/builder.py
+++ b/builder.py
@@ -51,7 +51,7 @@ class Builder(object):
def Build(self, board, pkg, additional_args):
"""Handles a build request from the cherrypy server."""
- cherrypy.log('Additional build request arguments: '+ str(additional_args),
+ cherrypy.log('Additional build request arguments: ' + str(additional_args),
'BUILD')
original_use = os.environ.get('USE', '')
@@ -59,6 +59,11 @@ class Builder(object):
os.environ['USE'] = original_use + ' ' + additional_args['use']
cherrypy.log('USE flags modified to ' + os.environ['USE'], 'BUILD')
+ if 'features' in additional_args:
+ os.environ['FEATURES'] = original_use + ' ' + additional_args['features']
rochberg 2011/04/09 19:59:34 = original_features + ... Probably best to switch
+ cherrypy.log('FEATURES flags modified to ' + os.environ['FEATURES'],
+ 'BUILD')
+
try:
if (self._ShouldBeWorkedOn(board, pkg) and
not additional_args.get('accept_stable')):
@@ -81,4 +86,4 @@ class Builder(object):
except OSError, e:
return self.SetError('Could not execute build command: ' + str(e))
finally:
- os.environ['USE'] = original_use
+ os.environ['USE'] = original_use
rochberg 2011/04/09 19:59:34 Should also restore FEATURES, or, better yet, be m
« no previous file with comments | « no previous file | gmerge » ('j') | gmerge » ('J')

Powered by Google App Engine
This is Rietveld 408576698