Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 6824021: Add features flag to gmerge. (Closed)

Created:
9 years, 8 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
rochberg
CC:
chromium-os-reviews_chromium.org, Daniel Erat
Visibility:
Public.

Description

Add features flag to gmerge and some whitespace cleanup. Change-Id: I95aec88a491b0aee08f100af72d608b326fcf9c4 BUG=chromium-os:13992 TEST=Ran sudo gmerge chromos-base/gmerge to update to latest gmerge and then ran sudo gmerge --features=test chromeos-base/metrics and saw test phase run on dev machine. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=dda923d

Patch Set 1 #

Total comments: 3

Patch Set 2 : Refactor to use environ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M builder.py View 1 3 chunks +11 lines, -7 lines 0 comments Download
M gmerge View 1 3 chunks +4 lines, -6 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
sosa
9 years, 8 months ago (2011-04-08 22:13:03 UTC) #1
rochberg
http://codereview.chromium.org/6824021/diff/1/builder.py File builder.py (right): http://codereview.chromium.org/6824021/diff/1/builder.py#newcode63 builder.py:63: os.environ['FEATURES'] = original_use + ' ' + additional_args['features'] = ...
9 years, 8 months ago (2011-04-09 19:59:33 UTC) #2
sosa
Took all your suggestions. PTAL http://codereview.chromium.org/6824021/diff/5001/gmerge File gmerge (right): http://codereview.chromium.org/6824021/diff/5001/gmerge#newcode123 gmerge:123: merger.SetupPortageEnvironment(os.environ) Move down to ...
9 years, 8 months ago (2011-04-13 20:04:08 UTC) #3
rochberg
9 years, 8 months ago (2011-04-13 20:10:59 UTC) #4
LGTM.
And that's totally the right way to do the env.

Powered by Google App Engine
This is Rietveld 408576698