Issue 6823078: Set chrome_dir as an absolute path. This makes the path to the hermetic Python still valid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6823078: Set chrome_dir as an absolute path. This makes the path to the hermetic Python still valid (Closed)

Created:
9 years, 8 months ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Set chrome_dir as an absolute path. This makes the path to the hermetic Python still valid when running subprocesses in a different working directory (cwd). For example, gyp\input.py does this when expanding variables. BUG=79166 TEST='gclient runhooks' succeeds under cygwin with no Python installed in depot_tools Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82088

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/gyp_chromium	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Pam (message me for reviews)

The symptom this addresses is that, if you install a fresh copy of depot_tools in ...

9 years, 8 months ago (2011-04-13 08:37:00 UTC) #1

LGTM

Expand Messages | Collapse Messages