Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 6823076: Fix functional tests notifications.NotificationsTest(s) (Closed)

Created:
9 years, 8 months ago by markusheintz_
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix functional tests: notifications.NotificationsTest.testAllowNotificationsFromAllSites notifications.NotificationsTest.testCrashRendererNotificationRemain notifications.NotificationsTest.testCreateDenyCloseNotifications notifications.NotificationsTest.testCreateHTMLNotification notifications.NotificationsTest.testCreateSimpleNotification BUG=76693 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81383

Patch Set 1 #

Patch Set 2 : " #

Total comments: 4

Patch Set 3 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M chrome/browser/content_settings/content_settings_pref_provider.cc View 1 2 3 chunks +22 lines, -2 lines 0 comments Download
M chrome/test/functional/notifications.py View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
markusheintz_
Pls review. THX
9 years, 8 months ago (2011-04-12 13:02:25 UTC) #1
markusheintz_
@kkania: Pleas review my CL. Thanks
9 years, 8 months ago (2011-04-12 15:53:30 UTC) #2
kkania
http://codereview.chromium.org/6823076/diff/2001/chrome/browser/content_settings/content_settings_pref_provider.cc File chrome/browser/content_settings/content_settings_pref_provider.cc (right): http://codereview.chromium.org/6823076/diff/2001/chrome/browser/content_settings/content_settings_pref_provider.cc#newcode79 chrome/browser/content_settings/content_settings_pref_provider.cc:79: default_settings->SetInteger(std::string(kTypeNames[i]), remove std::string http://codereview.chromium.org/6823076/diff/2001/chrome/browser/content_settings/content_settings_pref_provider.cc#newcode304 chrome/browser/content_settings/content_settings_pref_provider.cc:304: // expliciatly we set ...
9 years, 8 months ago (2011-04-12 16:42:42 UTC) #3
markusheintz_
http://codereview.chromium.org/6823076/diff/2001/chrome/browser/content_settings/content_settings_pref_provider.cc File chrome/browser/content_settings/content_settings_pref_provider.cc (right): http://codereview.chromium.org/6823076/diff/2001/chrome/browser/content_settings/content_settings_pref_provider.cc#newcode79 chrome/browser/content_settings/content_settings_pref_provider.cc:79: default_settings->SetInteger(std::string(kTypeNames[i]), On 2011/04/12 16:42:42, kkania wrote: > remove std::string ...
9 years, 8 months ago (2011-04-12 17:21:49 UTC) #4
kkania
LGTM it seems many of the other pyauto notifications tests are still failing still because ...
9 years, 8 months ago (2011-04-12 18:36:49 UTC) #5
kkania
9 years, 8 months ago (2011-04-12 18:37:31 UTC) #6
crbug.com/79054, to be clear

Powered by Google App Engine
This is Rietveld 408576698