chrome/browser/extensions/extension_input_api.cc - Issue 6823055: Consolidate OnKeyEvent and InputMethod code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_input_api.cc

Issue 6823055: Consolidate OnKeyEvent and InputMethod code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Refactor X2Event handling, nix Windows InputMethodDelegate, etc. Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_input_api.cc

diff --git a/chrome/browser/extensions/extension_input_api.cc b/chrome/browser/extensions/extension_input_api.cc

index b3b84731491f371ba47c278090a02d89479a88ea..aef56db54325493fa70db11784291f0bbb397c78 100644

--- a/chrome/browser/extensions/extension_input_api.cc

+++ b/chrome/browser/extensions/extension_input_api.cc

@@ -122,10 +122,7 @@ bool SendKeyboardEventInputFunction::RunImpl() {

}

views::KeyEvent event(type, prototype_event.key_code(), flags);

- views::InputMethod* ime = root_view->GetWidget()->GetInputMethod();

- if (ime) {

- ime->DispatchKeyEvent(event);

- } else if (!root_view->ProcessKeyEvent(event)) {

+ if (!root_view->GetWidget()->OnKeyEvent(event)) {

error_ = kKeyEventUnprocessedError;

return false;

}