Consolidate OnKeyEvent and InputMethod code.

chrome/browser/extensions/extension_input_api.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_input_api.h"
 
 #include <string>
 
 #include "base/string_util.h"
 #include "base/values.h"
@@ skipping 97 matching lines @@
     flags |= shift ? ui::EF_SHIFT_DOWN : 0;
   bool meta = false;
   if (args->GetBoolean(kMeta, &meta)) {
     // Views does not have a Meta event flag, so return an error for now.
     if (meta) {
       error_ = kUnsupportedModifier;
       return false;
     }
   }
 
   views::RootView* root_view = GetRootView();

[Ben Goodger (Google), 2011/04/20 23:12:05]

RootView is going to become an internal implementation detail of Widget. Can you
make this function return a Widget? That way you can just call OnKeyEvent on
Widget.

[msw, 2011/04/21 19:19:24]

Done.

   if (!root_view) {
     error_ = kNoValidRecipientError;
     return false;
   }
 
   views::KeyEvent event(type, prototype_event.key_code(), flags);
   views::InputMethod* ime = root_view->GetWidget()->GetInputMethod();
   if (ime) {
     ime->DispatchKeyEvent(event);
-  } else if (!root_view->ProcessKeyEvent(event)) {
+  } else if (!root_view->OnKeyEvent(event)) {
     error_ = kKeyEventUnprocessedError;
     return false;
   }
 
   return true;
 }