Consolidate OnKeyEvent and InputMethod code.

views/ime/input_method_delegate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_IME_INPUT_METHOD_DELEGATE_H_
 #define VIEWS_IME_INPUT_METHOD_DELEGATE_H_
 #pragma once
 
 namespace views {
 
 class KeyEvent;
 
 namespace internal {
 
 // An interface implemented by the object that handles events sent back from an
 // InputMethod implementation.
 class InputMethodDelegate {
  public:
   virtual ~InputMethodDelegate() {}
 
   // Dispatch a key event already processed by the input method.
-  virtual void DispatchKeyEventPostIME(const KeyEvent& key) = 0;
+  virtual bool DispatchKeyEventPostIME(const KeyEvent& key) = 0;

[Ben Goodger (Google), 2011/04/15 18:23:19]

Do you even still need this function?

I was thinking InputMethod::OnKeyEvent would return a bool indicating whether or
not the calling Widget should process further... which is effectively what this
function is doing. If you remove this then you can delete the whole delegate
interface.

[msw, 2011/04/15 19:19:57]

According to James, it's necessary, although I'm still unclear about exactly
why, see the included e-mail exchange.

Shall I invert the return value? Returning 'handled' (or 'no further handling
required') is a more common practice and semantically assumes less about the
caller's behavior.

 
 };
 
 }  // namespace internal
 }  // namespace views
 
 #endif  // VIEWS_IME_INPUT_METHOD_DELEGATE_H_