Fix crash in fade tab title change

Fix crash in fade tab title change

The fade tab title change is causing the browser to crash on some computers.

It looks like the problem is in BitmapPlatformDevice::create(). For some reason it's returning NULL.

This change just adds a NULL check and falls back to the old drawing code.

Once this is checked in I'll investigate what the root cause is.


BUG=78857
TEST=Compiled and ran.

[Peter Kasting, 2011-04-09 00:56:44]

LGTM

http://codereview.chromium.org/6823020/diff/1/ui/gfx/canvas_skia_win.cc
File ui/gfx/canvas_skia_win.cc (right):

http://codereview.chromium.org/6823020/diff/1/ui/gfx/canvas_skia_win.cc#newco...
ui/gfx/canvas_skia_win.cc:474: // Create a temporary bitmap to draw the gradient
to.
If this is really just a temporary hack, you should probably note that in your
comments.

[sail, 2011-04-09 01:07:23]

On 2011/04/09 00:56:44, Peter Kasting wrote:
> LGTM
> 
> http://codereview.chromium.org/6823020/diff/1/ui/gfx/canvas_skia_win.cc
> File ui/gfx/canvas_skia_win.cc (right):
> 
>
http://codereview.chromium.org/6823020/diff/1/ui/gfx/canvas_skia_win.cc#newco...
> ui/gfx/canvas_skia_win.cc:474: // Create a temporary bitmap to draw the
gradient
> to.
> If this is really just a temporary hack, you should probably note that in your
> comments.

I'm working on fixing the root cause. This NULL check is still a good idea
though since we shouldn't crash if a Windows API fails for some reason.

[Peter Kasting, 2011-04-09 01:11:05]

On 2011/04/09 01:07:23, sail wrote:
> I'm working on fixing the root cause. This NULL check is still a good idea
> though since we shouldn't crash if a Windows API fails for some reason.

I am not keen on handling API failures unless it's perfectly reasonable and
common for them to occur, and the rest of Chrome wouldn't be affected.  Most
places, doing something like [D]CHECK(result) is better.  For example, if
creating a platform bitmap can arbitrarily fail here, what about everywhere else
in Chrome we need to do it?  It seems to me that it's unlikely Chrome as a whole
can work well at that point, I'd rather just crash.

[commit-bot: I haz the power, 2011-04-09 01:56:09]

Change committed as 81026