Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: ppapi/cpp/var.h

Issue 6823016: Create a VarPrivate interface to contain the scripting helper functions of Var. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/cpp/private/var_private.cc ('k') | ppapi/cpp/var.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/var.h
===================================================================
--- ppapi/cpp/var.h (revision 81054)
+++ ppapi/cpp/var.h (working copy)
@@ -60,6 +60,8 @@
Var& operator=(const Var& other);
+ // For objects, dictionaries, and arrays, this operator compares object
+ // identity rather than value identity.
bool operator==(const Var& other) const;
bool is_undefined() const { return var_.type == PP_VARTYPE_UNDEFINED; }
@@ -195,14 +197,16 @@
PP_Var temp_;
};
+ protected:
+ PP_Var var_;
+ bool needs_release_;
+
private:
// Prevent an arbitrary pointer argument from being implicitly converted to
// a bool at Var construction. If somebody makes such a mistake, (s)he will
// get a compilation error.
Var(void* non_scriptable_object_pointer);
- PP_Var var_;
- bool needs_release_;
};
} // namespace pp
« no previous file with comments | « ppapi/cpp/private/var_private.cc ('k') | ppapi/cpp/var.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698