Create a VarPrivate interface to contain the scripting helper functions of Var.

ppapi/cpp/var.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/cpp/var.h"
 
 #include <stdio.h>
 #include <string.h>
 
 #include <algorithm>
@@ skipping 17 matching lines @@
 namespace {
 
 template <> const char* interface_name<PPB_Var_Deprecated>() {
   return PPB_VAR_DEPRECATED_INTERFACE;
 }
 
 // Technically you can call AddRef and Release on any Var, but it may involve
 // cross-process calls depending on the plugin. This is an optimization so we
 // only do refcounting on the necessary objects.
 inline bool NeedsRefcounting(const PP_Var& var) {
-  return var.type == PP_VARTYPE_STRING || var.type == PP_VARTYPE_OBJECT;
+  return var.type > PP_VARTYPE_DOUBLE;
 }
 
 }  // namespace
 
 using namespace deprecated;
 
 Var::Var() {
   var_.type = PP_VARTYPE_UNDEFINED;
   var_.padding = 0;
   needs_release_ = false;
@@ skipping 111 matching lines @@
     case PP_VARTYPE_BOOL:
       return AsBool() == other.AsBool();
     case PP_VARTYPE_INT32:
       return AsInt() == other.AsInt();
     case PP_VARTYPE_DOUBLE:
       return AsDouble() == other.AsDouble();
     case PP_VARTYPE_STRING:
       if (var_.value.as_id == other.var_.value.as_id)
         return true;
       return AsString() == other.AsString();
-    // TODO(neb): Document that this is === and not ==, unlike strings.
-    case PP_VARTYPE_OBJECT:
+    default:  // Objects, arrays, dictionaries.
       return var_.value.as_id == other.var_.value.as_id;
-    default:
-      return false;
   }
 }
 
 bool Var::AsBool() const {
   if (!is_bool()) {
     PP_NOTREACHED();
     return false;
   }
   return PPBoolToBool(var_.value.as_bool);
 }
@@ skipping 197 matching lines @@
       str.append("...");
     }
     snprintf(buf, sizeof(buf), format, str.c_str());
   } else if (is_object()) {
     snprintf(buf, sizeof(buf), "Var<OBJECT>");
   }
   return buf;
 }
 
 }  // namespace pp