Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 6822054: Fix load/store of external float arrays on ARM (Closed)

Created:
9 years, 8 months ago by Jakob Kummerow
Modified:
9 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Fix load/store of external float arrays on ARM BUG=1323 TEST=mjsunit/regress/regress-1323.js, run with simulator=arm Committed: http://code.google.com/p/v8/source/detail?r=7590

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -18 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 2 chunks +10 lines, -18 lines 0 comments Download
A test/mjsunit/regress/regress-1323.js View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
PTAL
9 years, 8 months ago (2011-04-12 14:41:28 UTC) #1
danno
http://codereview.chromium.org/6822054/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6822054/diff/1/src/arm/lithium-codegen-arm.cc#newcode3275 src/arm/lithium-codegen-arm.cc:3275: __ vstr(value.low(), scratch0(), 0); You need a corresponding UseTempRegister ...
9 years, 8 months ago (2011-04-12 15:10:50 UTC) #2
Jakob Kummerow
http://codereview.chromium.org/6822054/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6822054/diff/1/src/arm/lithium-codegen-arm.cc#newcode3275 src/arm/lithium-codegen-arm.cc:3275: __ vstr(value.low(), scratch0(), 0); On 2011/04/12 15:10:50, danno wrote: ...
9 years, 8 months ago (2011-04-12 15:13:39 UTC) #3
danno
9 years, 8 months ago (2011-04-12 15:20:01 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698