Issue 6822052: USB: cdc-acm: fix deadlock in acm_tty_open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6822052: USB: cdc-acm: fix deadlock in acm_tty_open (Closed)

Created:
9 years, 8 months ago by Vincent Palatin

Modified:
9 years, 7 months ago

Reviewers:
Benson Leung, Sonny

CC:
chromium-os-reviews_chromium.org, Jason Glasgow

Visibility:
Public.

USB: cdc-acm: fix deadlock in acm_tty_open The mutex must be dropped before calling usb_autopm_interface_put, else a concurrent call to acm_suspend will trigger a deadlock. BUG=chrome-os-partner:3143 TEST=run power_Resume test in tight loops on Alex. Signed-off-by: Vincent Palatin <vpalatin@chromium.org>; Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1d00bd3

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	drivers/usb/class/cdc-acm.c	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Vincent Palatin

[5/5] fix for the issues detected in the CDC ACM driver when running power_Resume test ...

9 years, 8 months ago (2011-04-12 12:22:00 UTC) #1

LGTM