Issue 6822028: factory_test_tools: improve gft_hwcomp (hardware_Components) performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6822028: factory_test_tools: improve gft_hwcomp (hardware_Components) performance (Closed)

Created:
9 years, 8 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Tom Wai-Hong Tam

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/factory_test_tools.git@master

Visibility:
Public.

Description

factory_test_tools: improve gft_hwcomp (hardware_Components) performance To improve HWID probing speed, we can fire multi-threads to collect information asynchronously. This gives 5 seconds improvements on Z* platform. BUG=chrome-os-partner:2505 TEST=time gft_hwcomp.py --sync # 18.483s time gft_hwcomp.py --async # 13.176s Gets 5.3 second improvements Change-Id: I017e93002a56ebd4e04ea7edbfde57fdc2ef2245 R=waihong@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=71cb1df

Patch Set 1 #

Patch Set 2 : improve performance from 15s -> 13s, add change command line param for new modes #

Patch Set 3 : add comments for why isolateing EC #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -24 lines)			Patch
	M	gft_common.py	View	1	2 chunks	+27 lines, -0 lines	0 comments	Download
	M	gft_hwcomp.py	View	1 2	8 chunks	+63 lines, -24 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Tom Wai-Hong Tam

9 years, 8 months ago (2011-04-13 01:19:36 UTC) #2

Good to know it has 5 sec improvement. LGTM w/ a nit.

http://codereview.chromium.org/6822028/diff/3003/gft_hwcomp.py
File gft_hwcomp.py (right):

http://codereview.chromium.org/6822028/diff/3003/gft_hwcomp.py#newcode762
gft_hwcomp.py:762: print 'Starting to detect %s...' % ('Asynchronously' if
do_async else '')
Asynchronously -> asynchronously

Expand Messages | Collapse Messages