Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 6821082: Integrate dynamic charts into autotest frontend. (Closed)

Created:
9 years, 8 months ago by truty1
Modified:
9 years, 7 months ago
Reviewers:
ericli, truty
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Integrate dynamic charts into autotest frontend. BUG=chromium-os:14044 TEST=http://truty.i/croschart/server/x86-mario-r12/MARIO_MP/0.12.306.0/0.12.389.0/platform_BootPerfServer/seconds_kernel_to_startup/1280/1024/ Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ddd44b2

Patch Set 1 #

Patch Set 2 : Add 2 charts url paths. #

Patch Set 3 : Add click-through to data per snanda. #

Patch Set 4 : Make multi-chart pages look like current pages. #

Total comments: 10

Patch Set 5 : Install gviz_api under site-packages. #

Patch Set 6 : Move defaults to a json file. #

Patch Set 7 : Simpler packaging. #

Patch Set 8 : Add license. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+539 lines, -1 line) Patch
M apache/conf/django-directives View 1 chunk +1 line, -1 line 0 comments Download
A frontend/croschart/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A frontend/croschart/common.py View 1 2 3 4 5 6 7 1 chunk +14 lines, -0 lines 0 comments Download
A frontend/croschart/croschart_defaults.json View 1 2 3 4 5 1 chunk +51 lines, -0 lines 0 comments Download
A frontend/croschart/models.py View 1 2 3 4 5 1 chunk +100 lines, -0 lines 0 comments Download
A frontend/croschart/templates/base.html View 1 chunk +133 lines, -0 lines 0 comments Download
A frontend/croschart/templates/charts.html View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A frontend/croschart/templates/plot_chart.html View 1 2 3 1 chunk +58 lines, -0 lines 0 comments Download
A frontend/croschart/templates/plot_unavailable.html View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A frontend/croschart/urls.py View 1 2 3 4 5 1 chunk +40 lines, -0 lines 0 comments Download
A frontend/croschart/views.py View 1 2 3 4 5 1 chunk +79 lines, -0 lines 0 comments Download
M frontend/settings.py View 2 chunks +4 lines, -1 line 0 comments Download
M frontend/urls.py View 2 chunks +2 lines, -0 lines 0 comments Download
M utils/external_packages.py View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
truty
Eric, would you please review?
9 years, 8 months ago (2011-04-13 21:52:46 UTC) #1
ericli
http://codereview.chromium.org/6821082/diff/6001/frontend/croschart/gviz_python/README File frontend/croschart/gviz_python/README (right): http://codereview.chromium.org/6821082/diff/6001/frontend/croschart/gviz_python/README#newcode16 frontend/croschart/gviz_python/README:16: python ./setup.py install do I need to do this ...
9 years, 8 months ago (2011-04-13 22:07:47 UTC) #2
truty
This is working very well. Here's another test url: http://truty.i/croschart/server/charts/x86-alex-r11/ALEX/320/240/ http://codereview.chromium.org/6821082/diff/6001/frontend/croschart/gviz_python/README File frontend/croschart/gviz_python/README (right): http://codereview.chromium.org/6821082/diff/6001/frontend/croschart/gviz_python/README#newcode16 ...
9 years, 8 months ago (2011-04-14 19:01:51 UTC) #3
ericli
9 years, 8 months ago (2011-04-14 21:40:47 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698