Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 6821072: factory_test_tools: support legacy probing mode (Closed)

Created:
9 years, 8 months ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
Tom Wai-Hong Tam
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

factory_test_tools: support legacy probing mode The new heuristic probing for USB/PCI devices is good, but it is possible to have some device that cannot be probed by the sysfs rules. To solve this issue, a new "legacy mode" is introduced: if an approved component list is simply full of traditional USB/PCI device info, we should ignore our heuristic search results and simply compare if the one of the component in list can be found on system. ex: id_wireless: ['1a1b:2b3c' '0030:1234], and the system has 0030:1234 installed but not as 'wlan0'. Before this fix, probing will result in id_wireless: [''] and give failure, after this fix probing will give ['0030:1234'] and success. BUG=chromium-os:13967 TEST=gft_hwcomp.py MODIFIED_COMPONENT # to have legacy fields only Change-Id: Ib3fb8d5a01bfb24fd84c10d611d9ff6f8637ef23 R=waihong@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3e99d09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -6 lines) Patch
M gft_hwcomp.py View 2 chunks +52 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hung-Te
9 years, 8 months ago (2011-04-12 10:05:12 UTC) #1
Tom Wai-Hong Tam
9 years, 8 months ago (2011-04-13 01:41:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698