Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 6821048: flimflam: Don't crash if LockType/RetriesLeft are not specified. (Closed)

Created:
9 years, 8 months ago by Elly Fong-Jones
Modified:
9 years, 4 months ago
Reviewers:
Jason Glasgow
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

flimflam: Don't crash if LockType/RetriesLeft are not specified. We should be resilient to the modem manager not filling these fields in. BUG=chromium-os:13968 TEST=Adhoc Run fake-cromo. Watch lack of crash :) Change-Id: I1ce556ec0584b83621a88af719024beba5975fe9 Signed-off-by: Elly Jones <ellyjones@chromium.org>; Signed-off-by: Jason Glasgow <jglasgow@chromium.org>; Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9f6f64f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/device.c View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elly Fong-Jones
9 years, 8 months ago (2011-04-11 17:03:29 UTC) #1
Jason Glasgow
9 years, 8 months ago (2011-04-11 17:06:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698