factory_test_tools: merge new properties from R11 factory hardware_Components

factory_test_tools: merge new properties from R11 factory hardware_Components

Some properties were only in R11 factory branch (old hardware_Components),
and we need to merge into R12 gooftool.

BUG=chrome-os-partner:2952, chrome-os-partner:2591
TEST=./gft_hwcomp allstar # seeing VPD data
     # and captured 3G firmware version by emulating data from
     # http://www.chromium.org/chromium-os/how-tos-and-troubleshooting/get-a-3g-modem-running

Change-Id: Ida0d0df94a8427af48eca3d3234d399c5a2674e2

R=yjlou@chromium.org,yongjaek@chromium.org

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4109e76

[Hung-Te, 2011-04-09 17:08:24]

yjlou: please review the keyboard part
jay: please review the 3g firmware part

[yongjaek, 2011-04-09 19:59:27]

+jglasgow

Jason - Is "modem status" available in ToT? I remembered that you added some
new tools for getting modem info. Please let us know.

Thanks,
Jay

On Sat, Apr 9, 2011 at 10:08 AM, <hungte@chromium.org> wrote:

> yjlou: please review the keyboard part
> jay: please review the 3g firmware part
>
>
> http://codereview.chromium.org/6821028/
>



-- 
Jay (Yong Jae) Kim
Software Integration Engineer | PSO | Google

[Hung-Te, 2011-04-10 05:22:58]

On 2011/04/09 19:59:27, yongjaek wrote:
> Jason - Is "modem status" available in ToT? I remembered that you added some
> new tools for getting modem info. Please let us know.

  "modem" is still available in ToT, at least now (I've verified that).
  Since we may need this to be ready very soon, I'm simply reusing the current
implementation from R11, with minimal modification, because I can't find working
3G modems to verify the execution results of mm.py.
  We can refine modem by mm.py in future.

[yongjaek, 2011-04-10 05:46:31]

Other than "modem status" the 3g firmware part LGTM

On 2011/04/10 05:22:58, Hung-Te wrote:
> On 2011/04/09 19:59:27, yongjaek wrote:
> > Jason - Is "modem status" available in ToT? I remembered that you added some
> > new tools for getting modem info. Please let us know.
> 
>   "modem" is still available in ToT, at least now (I've verified that).
>   Since we may need this to be ready very soon, I'm simply reusing the current
> implementation from R11, with minimal modification, because I can't find
working
> 3G modems to verify the execution results of mm.py.
>   We can refine modem by mm.py in future.

[yongjaek, 2011-04-10 05:47:57]

I mean modem status is ok as long as you are aware of Jason's revision plan.

[Hung-Te, 2011-04-10 05:52:59]

On 2011/04/10 05:47:57, yongjaek wrote:
> I mean modem status is ok as long as you are aware of Jason's revision plan.

 Marked that as a "TODO" item.

[Louis, 2011-04-11 02:43:12]

LGTM for keyboard part. Thanks.

http://codereview.chromium.org/6821028/diff/1003/gft_hwcomp.py
File gft_hwcomp.py (right):

http://codereview.chromium.org/6821028/diff/1003/gft_hwcomp.py#newcode295
gft_hwcomp.py:295: # VPD value "initial_locale"="en-US" should be listed.
Could you change the example as following to match your code:

  "keyboard_layout"="xkb:gb:extd:eng"

Thanks

http://codereview.chromium.org/6821028/diff/1003/gft_hwcomp.py#newcode298
gft_hwcomp.py:298: 'vpd -i RO_VPD -l -f %s | grep keyboard_layout | cut -f4
-d\\"' %
shall we escape -f %s like

  -f \\"%s\\"

Ignore this comment if image_file doesn't contain dangerous chars.

[Jason Glasgow, 2011-04-11 16:02:01]

modem status should be available in ToT.  It was moved to its own repository
http://git.chromium.org/gitweb/?p=modem-utilities.git;a=tree to make sure it was
always available.

FWIW, mm.py is also available in ToT and now works well with modem manager and
cromo.