Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2010 the V8 project authors. All rights reserved. | 1 // Copyright 2010 the V8 project authors. All rights reserved. |
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without |
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are |
| 4 // met: | 4 // met: |
| 5 // | 5 // |
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright |
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. |
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above |
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following |
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided |
| 11 // with the distribution. | 11 // with the distribution. |
| 12 // * Neither the name of Google Inc. nor the names of its | 12 // * Neither the name of Google Inc. nor the names of its |
| 13 // contributors may be used to endorse or promote products derived | 13 // contributors may be used to endorse or promote products derived |
| 14 // from this software without specific prior written permission. | 14 // from this software without specific prior written permission. |
| 15 // | 15 // |
| 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS |
| 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT |
| 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR |
| 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT |
| 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, |
| 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT |
| 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, |
| 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY |
| 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
| 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
| 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
| 27 | 27 |
| 28 // Flags: --allow-natives-syntax | |
| 29 | |
| 28 function Load(o) { | 30 function Load(o) { |
| 29 return o.outer.x | o.outer.inner.y; | 31 return o.outer.x | o.outer.inner.y; |
| 30 } | 32 } |
| 31 | 33 |
| 32 function StoreXY(o, x, y) { | 34 function StoreXY(o, x, y) { |
| 33 o.outer.x = x; | 35 o.outer.x = x; |
| 34 o.outer.inner.y = y; | 36 o.outer.inner.y = y; |
| 35 } | 37 } |
| 36 | 38 |
| 37 function LoadXY(x, y) { | 39 function LoadXY(x, y) { |
| 38 var object = { | 40 var object = { |
| 39 outer: { | 41 outer: { |
| 40 x: 0, | 42 x: 0, |
| 41 inner: { y: 0 } | 43 inner: { y: 0 } |
| 42 } | 44 } |
| 43 }; | 45 }; |
| 44 StoreXY(object, x, y); | 46 StoreXY(object, x, y); |
| 45 return Load(object); | 47 return Load(object); |
| 46 } | 48 } |
| 47 | 49 |
| 48 for (var i = 0; i < 10000; i++) LoadXY(i, i); | 50 for (var i = 0; i < 5; i++) LoadXY(i, i); |
| 51 %OptimizeFunctionOnNextCall(StoreXY); | |
|
Mads Ager (chromium)
2011/04/11 11:06:38
Similarly here. If you do not optimize this here,
Jakob Kummerow
2011/04/11 12:55:51
Yes, StoreXY does get inlined if only LoadXY is op
| |
| 52 LoadXY(6, 6); | |
| 53 %OptimizeFunctionOnNextCall(LoadXY); | |
| 54 LoadXY(7, 7); | |
| 49 assertEquals(42 | 87, LoadXY(42, 87)); | 55 assertEquals(42 | 87, LoadXY(42, 87)); |
| 50 assertEquals(42 | 87, LoadXY(42, 87)); | 56 assertEquals(42 | 87, LoadXY(42, 87)); |
| 51 assertEquals(42 | 99, LoadXY(42, "99")); | 57 assertEquals(42 | 99, LoadXY(42, "99")); |
| OLD | NEW |