[Mac] First pass at multiple selection in the tabstrip.

[Mac] First pass at multiple selection in the tabstrip.

This hooks up a new TabController state (called 'active') to indicate what
'selected' used to: key/focused state. The selected state can now be applied to
multiple TabControllers.

Currently only commands available through the context menu are usable for a
multi-tab selection. Support for dragging will come in a future CL.

The other notable chane is that tab activation now happens on |-mouseUp:|
rather than |-mouseDown:|, which is in preparation for multi-tab dragging.

BUG=78816
TEST=Shift click, Cmd click, and Cmd+Shift click to select tabs in different ways.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82543

[Avi (use Gerrit), 2011-04-08 15:22:19]

http://codereview.chromium.org/6821003/diff/1/chrome/browser/ui/cocoa/tabs/ta...
File chrome/browser/ui/cocoa/tabs/tab_controller.mm (right):

http://codereview.chromium.org/6821003/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_controller.mm:104: -
(void)internalSetSelected:(BOOL)selected {
I'm a little fuzzy on what this function is supposed to do. Both setActive and
setSelected call through to this. If we're setting a tab to "selected !active",
is it still appropriate to do all these things, like cancel alerts?

http://codereview.chromium.org/6821003/diff/1/chrome/browser/ui/cocoa/tabs/ta...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

http://codereview.chromium.org/6821003/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1779: NSView*
selectedTabView = nil;
If we're renaming the concept of "selected" to "active", perhaps it's worthwhile
to take the time to rename the surrounding variables, too. activeTabView, etc?

http://codereview.chromium.org/6821003/diff/1/chrome/browser/ui/tabs/tab_menu...
File chrome/browser/ui/tabs/tab_menu_model.cc (right):

http://codereview.chromium.org/6821003/diff/1/chrome/browser/ui/tabs/tab_menu...
chrome/browser/ui/tabs/tab_menu_model.cc:63: bool affects_multiple_tabs =
gah! nice

[Robert Sesek, 2011-04-09 14:23:07]

http://codereview.chromium.org/6821003/diff/1/chrome/browser/ui/cocoa/tabs/ta...
File chrome/browser/ui/cocoa/tabs/tab_controller.mm (right):

http://codereview.chromium.org/6821003/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_controller.mm:104: -
(void)internalSetSelected:(BOOL)selected {
On 2011/04/08 15:22:20, Avi wrote:
> I'm a little fuzzy on what this function is supposed to do. Both setActive and
> setSelected call through to this. If we're setting a tab to "selected
!active",
> is it still appropriate to do all these things, like cancel alerts?

The only thing that may not be appropriate is canceling alerts, but we still
need to update the visibility (to make tabs slightly bigger if we've got tiny
tabs) and to update the title color.

http://codereview.chromium.org/6821003/diff/1/chrome/browser/ui/cocoa/tabs/ta...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

http://codereview.chromium.org/6821003/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1779: NSView*
selectedTabView = nil;
On 2011/04/08 15:22:20, Avi wrote:
> If we're renaming the concept of "selected" to "active", perhaps it's
worthwhile
> to take the time to rename the surrounding variables, too. activeTabView, etc?

Done.

[Avi (use Gerrit), 2011-04-09 16:32:30]

http://codereview.chromium.org/6821003/diff/2002/chrome/browser/ui/cocoa/tabs...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.h (right):

http://codereview.chromium.org/6821003/diff/2002/chrome/browser/ui/cocoa/tabs...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.h:172: // Return the view for
the currently selected tab.
update comment: selected>active

http://codereview.chromium.org/6821003/diff/2002/chrome/browser/ui/cocoa/tabs...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.h:175: // Set the frame of the
selected tab, also updates the internal frame dict.
update comment: selected>active

http://codereview.chromium.org/6821003/diff/2002/chrome/browser/ui/cocoa/tabs...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

http://codereview.chromium.org/6821003/diff/2002/chrome/browser/ui/cocoa/tabs...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1167: -
(void)selectTabWithContents:(TabContentsWrapper*)newContents
activateTabWithConents:? You might want to do a find across ui/cocoa on "select"
to make sure you switch over all the appropriate names...

[Robert Sesek, 2011-04-19 21:03:38]

More renaming to match the methods that Scott has renamed since I first put this
up...

http://codereview.chromium.org/6821003/diff/2002/chrome/browser/ui/cocoa/tabs...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.h (right):

http://codereview.chromium.org/6821003/diff/2002/chrome/browser/ui/cocoa/tabs...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.h:172: // Return the view for
the currently selected tab.
On 2011/04/09 16:32:30, Avi wrote:
> update comment: selected>active

Done.

http://codereview.chromium.org/6821003/diff/2002/chrome/browser/ui/cocoa/tabs...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.h:175: // Set the frame of the
selected tab, also updates the internal frame dict.
On 2011/04/09 16:32:30, Avi wrote:
> update comment: selected>active

Done.

http://codereview.chromium.org/6821003/diff/2002/chrome/browser/ui/cocoa/tabs...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

http://codereview.chromium.org/6821003/diff/2002/chrome/browser/ui/cocoa/tabs...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1167: -
(void)selectTabWithContents:(TabContentsWrapper*)newContents
On 2011/04/09 16:32:30, Avi wrote:
> activateTabWithConents:? You might want to do a find across ui/cocoa on
"select"
> to make sure you switch over all the appropriate names...

The model observer and bridge haven't been fully renamed yet, so this is
probably going to happen piecemeal as Scott makes his way through the cleanup
tasks.

[Avi (use Gerrit), 2011-04-20 07:31:15]

The code LGTM. How much more harassment about renaming methods are you going to
take from me?

http://codereview.chromium.org/6821003/diff/7001/chrome/browser/ui/cocoa/tabs...
File chrome/browser/ui/cocoa/tabs/tab_window_controller.h (right):

http://codereview.chromium.org/6821003/diff/7001/chrome/browser/ui/cocoa/tabs...
chrome/browser/ui/cocoa/tabs/tab_window_controller.h:140: // Return the view of
the selected tab.
the active tab

http://codereview.chromium.org/6821003/diff/7001/chrome/browser/ui/cocoa/tabs...
chrome/browser/ui/cocoa/tabs/tab_window_controller.h:144: -
(NSString*)selectedTabTitle;
activeTabTitle?

[Robert Sesek, 2011-04-20 16:45:40]

On 2011/04/20 07:31:15, Avi wrote:
> The code LGTM. How much more harassment about renaming methods are you going
to
> take from me?

This week? No problem -- Rohit, Mark, and I are getting hardly anything done
here in MTV :p.

http://codereview.chromium.org/6821003/diff/7001/chrome/browser/ui/cocoa/tabs...
File chrome/browser/ui/cocoa/tabs/tab_window_controller.h (right):

http://codereview.chromium.org/6821003/diff/7001/chrome/browser/ui/cocoa/tabs...
chrome/browser/ui/cocoa/tabs/tab_window_controller.h:140: // Return the view of
the selected tab.
On 2011/04/20 07:31:15, Avi wrote:
> the active tab

Done.

http://codereview.chromium.org/6821003/diff/7001/chrome/browser/ui/cocoa/tabs...
chrome/browser/ui/cocoa/tabs/tab_window_controller.h:144: -
(NSString*)selectedTabTitle;
On 2011/04/20 07:31:15, Avi wrote:
> activeTabTitle?

Done.

[Avi (use Gerrit), 2011-04-20 23:36:21]

SLGTM

On Wed, Apr 20, 2011 at 12:45 PM, <rsesek@chromium.org> wrote:

> On 2011/04/20 07:31:15, Avi wrote:
>
>> The code LGTM. How much more harassment about renaming methods are you
>> going
>>
> to
>
>> take from me?
>>
>
> This week? No problem -- Rohit, Mark, and I are getting hardly anything
> done
> here in MTV :p.
>
>
>
>
>
http://codereview.chromium.org/6821003/diff/7001/chrome/browser/ui/cocoa/tabs...
> File chrome/browser/ui/cocoa/tabs/tab_window_controller.h (right):
>
>
>
http://codereview.chromium.org/6821003/diff/7001/chrome/browser/ui/cocoa/tabs...
> chrome/browser/ui/cocoa/tabs/tab_window_controller.h:140: // Return the
> view of the selected tab.
> On 2011/04/20 07:31:15, Avi wrote:
>
>> the active tab
>>
>
> Done.
>
>
>
>
http://codereview.chromium.org/6821003/diff/7001/chrome/browser/ui/cocoa/tabs...
> chrome/browser/ui/cocoa/tabs/tab_window_controller.h:144: -
> (NSString*)selectedTabTitle;
> On 2011/04/20 07:31:15, Avi wrote:
>
>> activeTabTitle?
>>
>
> Done.
>
>
> http://codereview.chromium.org/6821003/
>

[commit-bot: I haz the power, 2011-04-20 23:44:25]

Can't process patch for file
chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm.
File's status is None, patchset upload is incomplete.