Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 6821001: Support more than 9 arguments for ReplaceStringPlaceholders()

Created:
9 years, 8 months ago by haraken.dev
Modified:
9 years, 8 months ago
Reviewers:
tony
CC:
chromium-reviews
Visibility:
Public.

Description

Support more than 9 arguments for ReplaceStringPlaceholders() - support more than 9 arguments ($1, $2, $3, ..., $9 and $10, $11, $12, ...) for ReplaceStringPlaceholders() - add the unittest named ReplaceStringPlaceholdersMoreThan9Replacements for testing more than 9 arguments for ReplaceStringPlaceholders() BUG=16963 TEST=string_util_unittest:StringUtilTest.ReplaceStringPlaceholdersMoreThan9Replacements

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M base/string_util.cc View 2 chunks +8 lines, -2 lines 1 comment Download
M base/string_util_unittest.cc View 2 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken.dev_gmail.com
I am trying to fix the bug 16963. I found your name in git blame ...
9 years, 8 months ago (2011-04-08 13:06:59 UTC) #1
tony
9 years, 8 months ago (2011-04-08 16:39:53 UTC) #2
Also, have you signed the CLA?
http://code.google.com/legal/individual-cla-v1.0.html

If so, please add yourself to AUTHORS in this patch as well.

http://codereview.chromium.org/6821001/diff/1/base/string_util.cc
File base/string_util.cc (right):

http://codereview.chromium.org/6821001/diff/1/base/string_util.cc#newcode862
base/string_util.cc:862: ++i;
What happens if we're at the end of a string like "Foo$1"?  Won't we read past
the end of the string?  Can you add a test for this case?

Powered by Google App Engine
This is Rietveld 408576698