Issue 6820076: Add author to Change object. Don't set it yet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6820076: Add author to Change object. Don't set it yet. (Closed)

Created:
9 years, 8 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Add author to Change object. Don't set it yet. It's mostly to be used with the commit queue. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81326

Patch Set 1 #

Total comments: 3

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+134 lines, -59 lines)			Patch
M	gcl.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	git_cl.py	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	presubmit_support.py	View	5 chunks	+7 lines, -2 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	27 chunks	+117 lines, -54 lines	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

LGTM. Up to you if you want to make the suggested changes. http://codereview.chromium.org/6820076/diff/1/tests/presubmit_unittest.py File tests/presubmit_unittest.py ...

9 years, 8 months ago (2011-04-12 20:49:24 UTC) #2

M-A Ruel

9 years, 8 months ago (2011-04-12 23:13:24 UTC) #3

http://codereview.chromium.org/6820076/diff/1/tests/presubmit_unittest.py
File tests/presubmit_unittest.py (right):

http://codereview.chromium.org/6820076/diff/1/tests/presubmit_unittest.py#new...
tests/presubmit_unittest.py:351: change = presubmit.Change(
On 2011/04/12 20:49:24, Dirk Pranke wrote:
> maybe you should pull this into a helper routine (e.g., get_change()) with
> optional params to specify which parameters you care about?

I thought about that but didn't feel like doing it this time. Maybe next time.
:)

Expand Messages | Collapse Messages