Added TCPServerSocket.

net/socket/tcp_server_socket_unittest.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/compiler_specific.h"
+#include "base/scoped_ptr.h"
+#include "net/base/ip_endpoint.h"
+#include "net/base/net_errors.h"
+#include "net/socket/tcp_server_socket.h"

[willchan no longer on Chromium, 2011/04/13 16:08:51]

This include goes first.

[Sergey Ulanov, 2011/04/13 21:20:19]

Done.

+#include "net/base/test_completion_callback.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "testing/platform_test.h"
+
+namespace net {
+
+namespace {
+int kListenBacklog = 5;

[willchan no longer on Chromium, 2011/04/13 16:08:51]

const

[Sergey Ulanov, 2011/04/13 21:20:19]

Done.

+}  // namespace

[willchan no longer on Chromium, 2011/04/13 16:08:51]

How about putting all of this test code in the anonymous namespace?

[Sergey Ulanov, 2011/04/13 21:20:19]

Done.

+
+class TCPServerSocketTest : public PlatformTest {
+ protected:
+  void SetUp() OVERRIDE {
+    socket_.reset(new TCPServerSocket(NULL, NetLog::Source()));
+    IPEndPoint address;
+    ParseAddress("127.0.0.1", 0, &address);
+    ASSERT_EQ(0, socket_->Listen(address, kListenBacklog));
+    ASSERT_EQ(0, socket_->GetLocalAddress(&local_address_));
+  }
+
+  void ParseAddress(std::string ip_str, int port, IPEndPoint* address) {
+    IPAddressNumber ip_number;
+    bool rv = ParseIPLiteralToNumber(ip_str, &ip_number);
+    if (!rv)
+      return;
+    *address = IPEndPoint(ip_number, port);
+  }
+
+  scoped_ptr<TCPServerSocket> socket_;

[willchan no longer on Chromium, 2011/04/13 16:08:51]

Why are you using a scoped_ptr? Why not just directly embed the socket and
initialize it in the constructor's initializer list?

[Sergey Ulanov, 2011/04/13 21:20:19]

Done.

+  IPEndPoint local_address_;
+};
+
+TEST_F(TCPServerSocketTest, Accept) {
+  TestCompletionCallback connect_callback;
+  scoped_ptr<TCPClientSocket> connecting_socket(

[willchan no longer on Chromium, 2011/04/13 16:08:51]

I don't see why you use a scoped_ptr here instead of just allocating the
TCPClientSocket on the stack. Same with everywhere else.

[Sergey Ulanov, 2011/04/13 21:20:19]

Done.

+      new TCPClientSocket(AddressList(local_address_.address(),
+                                      local_address_.port(), false),
+                          NULL, NetLog::Source()));
+  connecting_socket->Connect(&connect_callback);
+
+  TestCompletionCallback accept_callback;
+  TCPClientSocket* accepted_socket;
+  IPEndPoint accepted_address;
+  int result = socket_->Accept(&accepted_socket, &accepted_address,
+                               &accept_callback);
+  if (result == ERR_IO_PENDING)
+    result = accept_callback.WaitForResult();
+  ASSERT_EQ(0, result);

[willchan no longer on Chromium, 2011/04/13 16:08:51]

Use OK instead of 0.

[Sergey Ulanov, 2011/04/13 21:20:19]

Done.

+
+  EXPECT_TRUE(accepted_socket != NULL);
+  // Both sockets should be on the loopback network interface.
+  EXPECT_EQ(accepted_address.address(), local_address_.address());
+
+  EXPECT_EQ(0, connect_callback.WaitForResult());

[willchan no longer on Chromium, 2011/04/13 16:08:51]

Ditto, please fix all other instances.

[Sergey Ulanov, 2011/04/13 21:20:19]

Done.

+
+  delete accepted_socket;
+}
+
+// Test Accept() callback.
+TEST_F(TCPServerSocketTest, AcceptAsync) {
+  TestCompletionCallback accept_callback;
+  TCPClientSocket* accepted_socket;
+  IPEndPoint accepted_address;
+
+  ASSERT_EQ(ERR_IO_PENDING,
+            socket_->Accept(&accepted_socket, &accepted_address,
+                            &accept_callback));
+
+  TestCompletionCallback connect_callback;
+  scoped_ptr<TCPClientSocket> connecting_socket(
+      new TCPClientSocket(AddressList(local_address_.address(),
+                                      local_address_.port(), false),
+                          NULL, NetLog::Source()));
+  connecting_socket->Connect(&connect_callback);
+
+  EXPECT_EQ(0, connect_callback.WaitForResult());
+  EXPECT_EQ(0, accept_callback.WaitForResult());
+
+  EXPECT_TRUE(accepted_socket != NULL);
+
+  // Both sockets should be on the loopback network interface.
+  EXPECT_EQ(accepted_address.address(), local_address_.address());
+
+  delete accepted_socket;
+}
+
+// Accept two connections simultaneously.
+TEST_F(TCPServerSocketTest, Accept2Connections) {
+  TestCompletionCallback accept_callback;
+  TCPClientSocket* accepted_socket;
+  IPEndPoint accepted_address;
+
+  ASSERT_EQ(ERR_IO_PENDING,
+            socket_->Accept(&accepted_socket, &accepted_address,
+                            &accept_callback));
+
+  TestCompletionCallback connect_callback;
+  scoped_ptr<TCPClientSocket> connecting_socket(
+      new TCPClientSocket(AddressList(local_address_.address(),
+                                      local_address_.port(), false),
+                          NULL, NetLog::Source()));
+  connecting_socket->Connect(&connect_callback);
+
+  TestCompletionCallback connect_callback2;
+  scoped_ptr<TCPClientSocket> connecting_socket2(
+      new TCPClientSocket(AddressList(local_address_.address(),
+                                      local_address_.port(), false),
+                          NULL, NetLog::Source()));
+  connecting_socket2->Connect(&connect_callback2);
+
+  EXPECT_EQ(0, accept_callback.WaitForResult());
+
+  TestCompletionCallback accept_callback2;
+  TCPClientSocket* accepted_socket2;
+  IPEndPoint accepted_address2;
+  int result = socket_->Accept(&accepted_socket2, &accepted_address2,
+                               &accept_callback2);
+  if (result == ERR_IO_PENDING)
+    result = accept_callback2.WaitForResult();
+  ASSERT_EQ(0, result);
+
+  EXPECT_EQ(0, connect_callback.WaitForResult());
+
+  EXPECT_TRUE(accepted_socket != NULL);
+  EXPECT_TRUE(accepted_socket2 != NULL);
+  EXPECT_NE(accepted_socket, accepted_socket2);
+
+  EXPECT_EQ(accepted_address.address(), local_address_.address());
+  EXPECT_EQ(accepted_address2.address(), local_address_.address());
+
+  delete accepted_socket;
+  delete accepted_socket2;
+}
+
+
+}  // namespace net