Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 6820038: Push the initial transform down into SkPDFDevice. (Chrome side). (Closed)

Created:
9 years, 8 months ago by vandebo (ex-Chrome)
Modified:
9 years, 7 months ago
Reviewers:
Chris Guillory, alokp
CC:
chromium-reviews
Visibility:
Public.

Description

Push the initial transform down into SkPDFDevice. (Chrome side). This change also rolls skis to r1111 to get the Skia side of the change. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81267

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Patch Set 3 : Rebase and roll Skia to r1111 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -56 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_skia.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M skia/ext/vector_platform_device_skia.h View 1 2 3 chunks +4 lines, -10 lines 0 comments Download
M skia/ext/vector_platform_device_skia.cc View 1 5 chunks +12 lines, -42 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vandebo (ex-Chrome)
9 years, 8 months ago (2011-04-11 17:06:02 UTC) #1
alokp
lgtm http://codereview.chromium.org/6820038/diff/1/skia/ext/vector_platform_device_skia.h File skia/ext/vector_platform_device_skia.h (right): http://codereview.chromium.org/6820038/diff/1/skia/ext/vector_platform_device_skia.h#newcode34 skia/ext/vector_platform_device_skia.h:34: VectorPlatformDeviceSkia(int width, int height, SkMatrix* initialTransform); may be ...
9 years, 8 months ago (2011-04-11 17:30:12 UTC) #2
Chris Guillory
LGTM with comments from Alok.
9 years, 8 months ago (2011-04-11 20:47:43 UTC) #3
vandebo (ex-Chrome)
http://codereview.chromium.org/6820038/diff/1/skia/ext/vector_platform_device_skia.h File skia/ext/vector_platform_device_skia.h (right): http://codereview.chromium.org/6820038/diff/1/skia/ext/vector_platform_device_skia.h#newcode34 skia/ext/vector_platform_device_skia.h:34: VectorPlatformDeviceSkia(int width, int height, SkMatrix* initialTransform); On 2011/04/11 17:30:12, ...
9 years, 8 months ago (2011-04-11 21:51:31 UTC) #4
Chris Guillory
9 years, 8 months ago (2011-04-12 16:37:09 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698