src/jsregexp.h - Issue 6820028: Mark single-argument inline constructors as 'explicit'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/jsregexp.h

Issue 6820028: Mark single-argument inline constructors as 'explicit'. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/jsregexp.h

diff --git a/src/jsregexp.h b/src/jsregexp.h

index 3ed5a7e43da743b3c4101d72a2e6192fff0755e6..b9b2f60406d9c68c4c823cdd6f452879ffdc3ea5 100644

--- a/src/jsregexp.h

+++ b/src/jsregexp.h

@@ -1447,7 +1447,7 @@ class RegExpEngine: public AllStatic {

class OffsetsVector {

public:

- inline OffsetsVector(int num_registers)

+ explicit inline OffsetsVector(int num_registers)

: offsets_vector_length_(num_registers) {

if (offsets_vector_length_ > Isolate::kJSRegexpStaticOffsetsVectorSize) {

vector_ = NewArray<int>(offsets_vector_length_);

« no previous file with comments | « src/heap.cc ('k') | src/mips/virtual-frame-mips.h » ('j') | no next file with comments »