src/heap.cc - Issue 6820028: Mark single-argument inline constructors as 'explicit'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 6820028: Mark single-argument inline constructors as 'explicit'. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index b2e09b40db5131dc56b46b619c844891028455db..c77364b55305019dffc757d789442bc5c9eca0ac 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -3231,7 +3231,7 @@ MaybeObject* Heap::AllocateGlobalObject(JSFunction* constructor) {

// Fill these accessors into the dictionary.

DescriptorArray* descs = map->instance_descriptors();

for (int i = 0; i < descs->number_of_descriptors(); i++) {

- PropertyDetails details = descs->GetDetails(i);

+ PropertyDetails details(descs->GetDetails(i));

ASSERT(details.type() == CALLBACKS); // Only accessors are expected.

PropertyDetails d =

PropertyDetails(details.attributes(), CALLBACKS, details.index());

« no previous file with comments | « src/api.h ('k') | src/jsregexp.h » ('j') | no next file with comments »