Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: src/property.h

Issue 6820028: Mark single-argument inline constructors as 'explicit'. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-inl.h ('k') | src/scopeinfo.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 cacheable_(true), 178 cacheable_(true),
179 details_(NONE, NORMAL) {} 179 details_(NONE, NORMAL) {}
180 180
181 void DescriptorResult(JSObject* holder, PropertyDetails details, int number) { 181 void DescriptorResult(JSObject* holder, PropertyDetails details, int number) {
182 lookup_type_ = DESCRIPTOR_TYPE; 182 lookup_type_ = DESCRIPTOR_TYPE;
183 holder_ = holder; 183 holder_ = holder;
184 details_ = details; 184 details_ = details;
185 number_ = number; 185 number_ = number;
186 } 186 }
187 187
188 void DescriptorResult(JSObject* holder, Smi* details, int number) {
189 lookup_type_ = DESCRIPTOR_TYPE;
190 holder_ = holder;
191 details_ = PropertyDetails(details);
192 number_ = number;
193 }
194
188 void ConstantResult(JSObject* holder) { 195 void ConstantResult(JSObject* holder) {
189 lookup_type_ = CONSTANT_TYPE; 196 lookup_type_ = CONSTANT_TYPE;
190 holder_ = holder; 197 holder_ = holder;
191 details_ = 198 details_ =
192 PropertyDetails(static_cast<PropertyAttributes>(DONT_ENUM | 199 PropertyDetails(static_cast<PropertyAttributes>(DONT_ENUM |
193 DONT_DELETE), 200 DONT_DELETE),
194 CALLBACKS); 201 CALLBACKS);
195 number_ = -1; 202 number_ = -1;
196 } 203 }
197 204
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 JSObject* holder_; 346 JSObject* holder_;
340 int number_; 347 int number_;
341 bool cacheable_; 348 bool cacheable_;
342 PropertyDetails details_; 349 PropertyDetails details_;
343 }; 350 };
344 351
345 352
346 } } // namespace v8::internal 353 } } // namespace v8::internal
347 354
348 #endif // V8_PROPERTY_H_ 355 #endif // V8_PROPERTY_H_
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/scopeinfo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698